You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/07/30 11:33:16 UTC

[GitHub] [camel-kafka-connector] orpiske edited a comment on pull request #343: Set default and doc config properties as private

orpiske edited a comment on pull request #343:
URL: https://github.com/apache/camel-kafka-connector/pull/343#issuecomment-666311561


   I agree that moving to private would follow generally accepted good practices (for lack of a better "term"). However, I still feel -1 towards making it private. My feeling towards this comes from the fact that Kafka seems to also use [public visibility](https://github.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java#L98) on their code base.
   
   Even though these are separate projects, I believe that maintaining them as `public` would be consistent to how it is done right now on the Kafka Connect code base. I believe that maintaining this consistency could simplify the job for developers looking to extend the Camel Kafka Connect connectors.
   
   Therefore, my suggestion is -1.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org