You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by William Tam <em...@gmail.com> on 2009/08/05 00:33:46 UTC

[HEADUP] cxfbean header change

I am proposing to replace component local header
"CamelCxfBeanRequestBasePath" in cxfbean by a new header
"CamelHttpBaseUri" to be defined in Exchange.java.   That can improve
interoperability between components that deal with HTTP/REST.  Let me
know if there is any concerns.  Thx.

- William



Index: camel-core/src/main/java/org/apache/camel/Exchange.java
===================================================================
--- camel-core/src/main/java/org/apache/camel/Exchange.java	(revision 800771)
+++ camel-core/src/main/java/org/apache/camel/Exchange.java	(working copy)
@@ -69,6 +69,7 @@

     String GROUPED_EXCHANGE = "CamelGroupedExchange";

+    String HTTP_BASE_URI           = "CamelHttpBaseUri";
     String HTTP_CHARACTER_ENCODING = "CamelHttpCharacterEncoding";
     String HTTP_METHOD             = "CamelHttpMethod";
     String HTTP_PATH               = "CamelHttpPath";

Re: [HEADUP] cxfbean header change

Posted by Claus Ibsen <cl...@gmail.com>.
On Wed, Aug 5, 2009 at 6:06 PM, William Tam<em...@gmail.com> wrote:
> Committed revision 801278 and 801279.   I still want to get some
> improvement for CAMEL-1737 in for the release.  In camel cxf jaxrs
> producer, I want to be able to propagate headers to/from camel
> exchange as well as getting response code in the camel header.   I
> need about 3 hours.   Is that OK?
>

No problem. We anticipate that 2 RC need to be done before its final.
And I guess Hadrian will cut the first RC tomorrow/weekend.

But anyway try to get your changes in the first RC. Just we dont want
any losses ends, with a 50% impl feature.

> - William
>
> On Wed, Aug 5, 2009 at 9:20 AM, William Tam<em...@gmail.com> wrote:
>> It will be done today.
>>
>> - William
>>
>> On Wed, Aug 5, 2009 at 8:21 AM, Claus Ibsen<cl...@gmail.com> wrote:
>>> Tam what is the ETA on this?
>>>
>>> We are almost ready for 2.0 release and want to be able to do a release soon.
>>>
>>>
>>> On Wed, Aug 5, 2009 at 7:31 AM, Claus Ibsen<cl...@gmail.com> wrote:
>>>> And you can make it just before 2.0 goes final.
>>>>
>>>> +1
>>>>
>>>>
>>>>
>>>> On Wed, Aug 5, 2009 at 3:54 AM, Hadrian Zbarcea<hz...@gmail.com> wrote:
>>>>> +1
>>>>> Hadrian
>>>>>
>>>>> On Aug 4, 2009, at 6:33 PM, William Tam wrote:
>>>>>
>>>>>> I am proposing to replace component local header
>>>>>> "CamelCxfBeanRequestBasePath" in cxfbean by a new header
>>>>>> "CamelHttpBaseUri" to be defined in Exchange.java.   That can improve
>>>>>> interoperability between components that deal with HTTP/REST.  Let me
>>>>>> know if there is any concerns.  Thx.
>>>>>>
>>>>>> - William
>>>>>>
>>>>>>
>>>>>>
>>>>>> Index: camel-core/src/main/java/org/apache/camel/Exchange.java
>>>>>> ===================================================================
>>>>>> --- camel-core/src/main/java/org/apache/camel/Exchange.java     (revision
>>>>>> 800771)
>>>>>> +++ camel-core/src/main/java/org/apache/camel/Exchange.java     (working
>>>>>> copy)
>>>>>> @@ -69,6 +69,7 @@
>>>>>>
>>>>>>    String GROUPED_EXCHANGE = "CamelGroupedExchange";
>>>>>>
>>>>>> +    String HTTP_BASE_URI           = "CamelHttpBaseUri";
>>>>>>    String HTTP_CHARACTER_ENCODING = "CamelHttpCharacterEncoding";
>>>>>>    String HTTP_METHOD             = "CamelHttpMethod";
>>>>>>    String HTTP_PATH               = "CamelHttpPath";
>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Claus Ibsen
>>>> Apache Camel Committer
>>>>
>>>> Open Source Integration: http://fusesource.com
>>>> Blog: http://davsclaus.blogspot.com/
>>>> Twitter: http://twitter.com/davsclaus
>>>>
>>>
>>>
>>>
>>> --
>>> Claus Ibsen
>>> Apache Camel Committer
>>>
>>> Open Source Integration: http://fusesource.com
>>> Blog: http://davsclaus.blogspot.com/
>>> Twitter: http://twitter.com/davsclaus
>>>
>>
>



-- 
Claus Ibsen
Apache Camel Committer

Open Source Integration: http://fusesource.com
Blog: http://davsclaus.blogspot.com/
Twitter: http://twitter.com/davsclaus

Re: [HEADUP] cxfbean header change

Posted by William Tam <em...@gmail.com>.
Committed revision 801278 and 801279.   I still want to get some
improvement for CAMEL-1737 in for the release.  In camel cxf jaxrs
producer, I want to be able to propagate headers to/from camel
exchange as well as getting response code in the camel header.   I
need about 3 hours.   Is that OK?

- William

On Wed, Aug 5, 2009 at 9:20 AM, William Tam<em...@gmail.com> wrote:
> It will be done today.
>
> - William
>
> On Wed, Aug 5, 2009 at 8:21 AM, Claus Ibsen<cl...@gmail.com> wrote:
>> Tam what is the ETA on this?
>>
>> We are almost ready for 2.0 release and want to be able to do a release soon.
>>
>>
>> On Wed, Aug 5, 2009 at 7:31 AM, Claus Ibsen<cl...@gmail.com> wrote:
>>> And you can make it just before 2.0 goes final.
>>>
>>> +1
>>>
>>>
>>>
>>> On Wed, Aug 5, 2009 at 3:54 AM, Hadrian Zbarcea<hz...@gmail.com> wrote:
>>>> +1
>>>> Hadrian
>>>>
>>>> On Aug 4, 2009, at 6:33 PM, William Tam wrote:
>>>>
>>>>> I am proposing to replace component local header
>>>>> "CamelCxfBeanRequestBasePath" in cxfbean by a new header
>>>>> "CamelHttpBaseUri" to be defined in Exchange.java.   That can improve
>>>>> interoperability between components that deal with HTTP/REST.  Let me
>>>>> know if there is any concerns.  Thx.
>>>>>
>>>>> - William
>>>>>
>>>>>
>>>>>
>>>>> Index: camel-core/src/main/java/org/apache/camel/Exchange.java
>>>>> ===================================================================
>>>>> --- camel-core/src/main/java/org/apache/camel/Exchange.java     (revision
>>>>> 800771)
>>>>> +++ camel-core/src/main/java/org/apache/camel/Exchange.java     (working
>>>>> copy)
>>>>> @@ -69,6 +69,7 @@
>>>>>
>>>>>    String GROUPED_EXCHANGE = "CamelGroupedExchange";
>>>>>
>>>>> +    String HTTP_BASE_URI           = "CamelHttpBaseUri";
>>>>>    String HTTP_CHARACTER_ENCODING = "CamelHttpCharacterEncoding";
>>>>>    String HTTP_METHOD             = "CamelHttpMethod";
>>>>>    String HTTP_PATH               = "CamelHttpPath";
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Claus Ibsen
>>> Apache Camel Committer
>>>
>>> Open Source Integration: http://fusesource.com
>>> Blog: http://davsclaus.blogspot.com/
>>> Twitter: http://twitter.com/davsclaus
>>>
>>
>>
>>
>> --
>> Claus Ibsen
>> Apache Camel Committer
>>
>> Open Source Integration: http://fusesource.com
>> Blog: http://davsclaus.blogspot.com/
>> Twitter: http://twitter.com/davsclaus
>>
>

Re: [HEADUP] cxfbean header change

Posted by William Tam <em...@gmail.com>.
It will be done today.

- William

On Wed, Aug 5, 2009 at 8:21 AM, Claus Ibsen<cl...@gmail.com> wrote:
> Tam what is the ETA on this?
>
> We are almost ready for 2.0 release and want to be able to do a release soon.
>
>
> On Wed, Aug 5, 2009 at 7:31 AM, Claus Ibsen<cl...@gmail.com> wrote:
>> And you can make it just before 2.0 goes final.
>>
>> +1
>>
>>
>>
>> On Wed, Aug 5, 2009 at 3:54 AM, Hadrian Zbarcea<hz...@gmail.com> wrote:
>>> +1
>>> Hadrian
>>>
>>> On Aug 4, 2009, at 6:33 PM, William Tam wrote:
>>>
>>>> I am proposing to replace component local header
>>>> "CamelCxfBeanRequestBasePath" in cxfbean by a new header
>>>> "CamelHttpBaseUri" to be defined in Exchange.java.   That can improve
>>>> interoperability between components that deal with HTTP/REST.  Let me
>>>> know if there is any concerns.  Thx.
>>>>
>>>> - William
>>>>
>>>>
>>>>
>>>> Index: camel-core/src/main/java/org/apache/camel/Exchange.java
>>>> ===================================================================
>>>> --- camel-core/src/main/java/org/apache/camel/Exchange.java     (revision
>>>> 800771)
>>>> +++ camel-core/src/main/java/org/apache/camel/Exchange.java     (working
>>>> copy)
>>>> @@ -69,6 +69,7 @@
>>>>
>>>>    String GROUPED_EXCHANGE = "CamelGroupedExchange";
>>>>
>>>> +    String HTTP_BASE_URI           = "CamelHttpBaseUri";
>>>>    String HTTP_CHARACTER_ENCODING = "CamelHttpCharacterEncoding";
>>>>    String HTTP_METHOD             = "CamelHttpMethod";
>>>>    String HTTP_PATH               = "CamelHttpPath";
>>>
>>>
>>
>>
>>
>> --
>> Claus Ibsen
>> Apache Camel Committer
>>
>> Open Source Integration: http://fusesource.com
>> Blog: http://davsclaus.blogspot.com/
>> Twitter: http://twitter.com/davsclaus
>>
>
>
>
> --
> Claus Ibsen
> Apache Camel Committer
>
> Open Source Integration: http://fusesource.com
> Blog: http://davsclaus.blogspot.com/
> Twitter: http://twitter.com/davsclaus
>

Re: [HEADUP] cxfbean header change

Posted by Claus Ibsen <cl...@gmail.com>.
Tam what is the ETA on this?

We are almost ready for 2.0 release and want to be able to do a release soon.


On Wed, Aug 5, 2009 at 7:31 AM, Claus Ibsen<cl...@gmail.com> wrote:
> And you can make it just before 2.0 goes final.
>
> +1
>
>
>
> On Wed, Aug 5, 2009 at 3:54 AM, Hadrian Zbarcea<hz...@gmail.com> wrote:
>> +1
>> Hadrian
>>
>> On Aug 4, 2009, at 6:33 PM, William Tam wrote:
>>
>>> I am proposing to replace component local header
>>> "CamelCxfBeanRequestBasePath" in cxfbean by a new header
>>> "CamelHttpBaseUri" to be defined in Exchange.java.   That can improve
>>> interoperability between components that deal with HTTP/REST.  Let me
>>> know if there is any concerns.  Thx.
>>>
>>> - William
>>>
>>>
>>>
>>> Index: camel-core/src/main/java/org/apache/camel/Exchange.java
>>> ===================================================================
>>> --- camel-core/src/main/java/org/apache/camel/Exchange.java     (revision
>>> 800771)
>>> +++ camel-core/src/main/java/org/apache/camel/Exchange.java     (working
>>> copy)
>>> @@ -69,6 +69,7 @@
>>>
>>>    String GROUPED_EXCHANGE = "CamelGroupedExchange";
>>>
>>> +    String HTTP_BASE_URI           = "CamelHttpBaseUri";
>>>    String HTTP_CHARACTER_ENCODING = "CamelHttpCharacterEncoding";
>>>    String HTTP_METHOD             = "CamelHttpMethod";
>>>    String HTTP_PATH               = "CamelHttpPath";
>>
>>
>
>
>
> --
> Claus Ibsen
> Apache Camel Committer
>
> Open Source Integration: http://fusesource.com
> Blog: http://davsclaus.blogspot.com/
> Twitter: http://twitter.com/davsclaus
>



-- 
Claus Ibsen
Apache Camel Committer

Open Source Integration: http://fusesource.com
Blog: http://davsclaus.blogspot.com/
Twitter: http://twitter.com/davsclaus

Re: [HEADUP] cxfbean header change

Posted by Claus Ibsen <cl...@gmail.com>.
And you can make it just before 2.0 goes final.

+1



On Wed, Aug 5, 2009 at 3:54 AM, Hadrian Zbarcea<hz...@gmail.com> wrote:
> +1
> Hadrian
>
> On Aug 4, 2009, at 6:33 PM, William Tam wrote:
>
>> I am proposing to replace component local header
>> "CamelCxfBeanRequestBasePath" in cxfbean by a new header
>> "CamelHttpBaseUri" to be defined in Exchange.java.   That can improve
>> interoperability between components that deal with HTTP/REST.  Let me
>> know if there is any concerns.  Thx.
>>
>> - William
>>
>>
>>
>> Index: camel-core/src/main/java/org/apache/camel/Exchange.java
>> ===================================================================
>> --- camel-core/src/main/java/org/apache/camel/Exchange.java     (revision
>> 800771)
>> +++ camel-core/src/main/java/org/apache/camel/Exchange.java     (working
>> copy)
>> @@ -69,6 +69,7 @@
>>
>>    String GROUPED_EXCHANGE = "CamelGroupedExchange";
>>
>> +    String HTTP_BASE_URI           = "CamelHttpBaseUri";
>>    String HTTP_CHARACTER_ENCODING = "CamelHttpCharacterEncoding";
>>    String HTTP_METHOD             = "CamelHttpMethod";
>>    String HTTP_PATH               = "CamelHttpPath";
>
>



-- 
Claus Ibsen
Apache Camel Committer

Open Source Integration: http://fusesource.com
Blog: http://davsclaus.blogspot.com/
Twitter: http://twitter.com/davsclaus

Re: [HEADUP] cxfbean header change

Posted by Hadrian Zbarcea <hz...@gmail.com>.
+1
Hadrian

On Aug 4, 2009, at 6:33 PM, William Tam wrote:

> I am proposing to replace component local header
> "CamelCxfBeanRequestBasePath" in cxfbean by a new header
> "CamelHttpBaseUri" to be defined in Exchange.java.   That can improve
> interoperability between components that deal with HTTP/REST.  Let me
> know if there is any concerns.  Thx.
>
> - William
>
>
>
> Index: camel-core/src/main/java/org/apache/camel/Exchange.java
> ===================================================================
> --- camel-core/src/main/java/org/apache/camel/Exchange.java	 
> (revision 800771)
> +++ camel-core/src/main/java/org/apache/camel/Exchange.java	(working  
> copy)
> @@ -69,6 +69,7 @@
>
>     String GROUPED_EXCHANGE = "CamelGroupedExchange";
>
> +    String HTTP_BASE_URI           = "CamelHttpBaseUri";
>     String HTTP_CHARACTER_ENCODING = "CamelHttpCharacterEncoding";
>     String HTTP_METHOD             = "CamelHttpMethod";
>     String HTTP_PATH               = "CamelHttpPath";


Re: [HEADUP] cxfbean header change

Posted by William Tam <em...@gmail.com>.
yea, i'll make sure the wiki page get updated.

On Tue, Aug 4, 2009 at 8:08 PM, Willem Jiang<wi...@gmail.com> wrote:
> Hi William,
>
> I think it should be OK as the header is new to Exchange.
> And you may need to go through the http transport related components to make
> this header really work :)
>
> Willem
>
> William Tam wrote:
>>
>> I am proposing to replace component local header
>> "CamelCxfBeanRequestBasePath" in cxfbean by a new header
>> "CamelHttpBaseUri" to be defined in Exchange.java.   That can improve
>> interoperability between components that deal with HTTP/REST.  Let me
>> know if there is any concerns.  Thx.
>>
>> - William
>>
>>
>>
>> Index: camel-core/src/main/java/org/apache/camel/Exchange.java
>> ===================================================================
>> --- camel-core/src/main/java/org/apache/camel/Exchange.java     (revision
>> 800771)
>> +++ camel-core/src/main/java/org/apache/camel/Exchange.java     (working
>> copy)
>> @@ -69,6 +69,7 @@
>>
>>     String GROUPED_EXCHANGE = "CamelGroupedExchange";
>>
>> +    String HTTP_BASE_URI           = "CamelHttpBaseUri";
>>     String HTTP_CHARACTER_ENCODING = "CamelHttpCharacterEncoding";
>>     String HTTP_METHOD             = "CamelHttpMethod";
>>     String HTTP_PATH               = "CamelHttpPath";
>>
>
>

Re: [HEADUP] cxfbean header change

Posted by Willem Jiang <wi...@gmail.com>.
Hi William,

I think it should be OK as the header is new to Exchange.
And you may need to go through the http transport related components to 
make this header really work :)

Willem

William Tam wrote:
> I am proposing to replace component local header
> "CamelCxfBeanRequestBasePath" in cxfbean by a new header
> "CamelHttpBaseUri" to be defined in Exchange.java.   That can improve
> interoperability between components that deal with HTTP/REST.  Let me
> know if there is any concerns.  Thx.
> 
> - William
> 
> 
> 
> Index: camel-core/src/main/java/org/apache/camel/Exchange.java
> ===================================================================
> --- camel-core/src/main/java/org/apache/camel/Exchange.java	(revision 800771)
> +++ camel-core/src/main/java/org/apache/camel/Exchange.java	(working copy)
> @@ -69,6 +69,7 @@
> 
>      String GROUPED_EXCHANGE = "CamelGroupedExchange";
> 
> +    String HTTP_BASE_URI           = "CamelHttpBaseUri";
>      String HTTP_CHARACTER_ENCODING = "CamelHttpCharacterEncoding";
>      String HTTP_METHOD             = "CamelHttpMethod";
>      String HTTP_PATH               = "CamelHttpPath";
>