You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Paul Brett <pa...@twopensource.com> on 2015/07/09 00:50:51 UTC
Review Request 36336: Expose major,
minor and patch components from stout Version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36336/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, Kapil Arya, and Vinod Kone.
Bugs: MESOS-3020
https://issues.apache.org/jira/browse/MESOS-3020
Repository: mesos
Description
-------
Expose major, minor and patch components from stout Version
Note: The names major and minor are not available when compiling with GCC because it pulls in the sysmacros.h header implicitly which define these for makedev.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 8692323d28131cd5706dde0503d49f8f0b0a1aeb
Diff: https://reviews.apache.org/r/36336/diff/
Testing
-------
sudo make check
Thanks,
Paul Brett
Re: Review Request 36336: Expose major,
minor and patch components from stout Version
Posted by Ben Mahler <be...@gmail.com>.
> On July 9, 2015, 2:46 a.m., Kapil Arya wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, line 36
> > <https://reviews.apache.org/r/36336/diff/1/?file=1002978#file1002978line36>
> >
> > Why do we want to rename major/minor/patch to primary/secondary/tertiary? The former is a widely accepted format.
>
> Paul Brett wrote:
> g++ defines _GNU_SOURCE (required for libstdc++). This #includes sysmacros.h which #define major and minor as macros for makedev.
If you add major(), minor(), patch() as methods instead, does that bypass the macro issue?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36336/#review91047
-----------------------------------------------------------
On July 8, 2015, 10:50 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36336/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 10:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-3020
> https://issues.apache.org/jira/browse/MESOS-3020
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Expose major, minor and patch components from stout Version
>
> Note: The names major and minor are not available when compiling with GCC because it pulls in the sysmacros.h header implicitly which define these for makedev.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 8692323d28131cd5706dde0503d49f8f0b0a1aeb
>
> Diff: https://reviews.apache.org/r/36336/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 36336: Expose major,
minor and patch components from stout Version
Posted by Paul Brett <pa...@twopensource.com>.
> On July 9, 2015, 2:46 a.m., Kapil Arya wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, line 36
> > <https://reviews.apache.org/r/36336/diff/1/?file=1002978#file1002978line36>
> >
> > Why do we want to rename major/minor/patch to primary/secondary/tertiary? The former is a widely accepted format.
>
> Paul Brett wrote:
> g++ defines _GNU_SOURCE (required for libstdc++). This #includes sysmacros.h which #define major and minor as macros for makedev.
>
> Ben Mahler wrote:
> If you add major(), minor(), patch() as methods instead, does that bypass the macro issue?
>
> Paul Brett wrote:
> No, that doesn't work. At the calling site, x.major() gets expanded to x.gnu_dev_major() by the macro.
>
> Kapil Arya wrote:
> Can we just `#undef` the macros for this file. AFAIK, we aren't using them in the source code.
>
> Paul Brett wrote:
> We could but we would be doing that in a header file which would impact everyone who might ever include stout version directly or indirectly. How about we use getMajor(), getMinor() and getPatch() accessor methods?
>
> Ben Mahler wrote:
> Per our chat, how about majorVersion(), minorVersion(), patchVersion() with a note for posterity?
>
> With getMajor(), seems callers might still be likely to call their variable 'major': `unsigned int major = version.getMajor()`
Changed to majorVersion, minorVersion and patchVersion.
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36336/#review91047
-----------------------------------------------------------
On July 9, 2015, 10:06 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36336/
> -----------------------------------------------------------
>
> (Updated July 9, 2015, 10:06 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-3020
> https://issues.apache.org/jira/browse/MESOS-3020
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Expose major, minor and patch components from stout Version
>
> Note: The names major and minor are not available when compiling with GCC because it pulls in the sysmacros.h header implicitly which define these for makedev.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 8692323d28131cd5706dde0503d49f8f0b0a1aeb
>
> Diff: https://reviews.apache.org/r/36336/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 36336: Expose major,
minor and patch components from stout Version
Posted by Paul Brett <pa...@twopensource.com>.
> On July 9, 2015, 2:46 a.m., Kapil Arya wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, line 36
> > <https://reviews.apache.org/r/36336/diff/1/?file=1002978#file1002978line36>
> >
> > Why do we want to rename major/minor/patch to primary/secondary/tertiary? The former is a widely accepted format.
>
> Paul Brett wrote:
> g++ defines _GNU_SOURCE (required for libstdc++). This #includes sysmacros.h which #define major and minor as macros for makedev.
>
> Ben Mahler wrote:
> If you add major(), minor(), patch() as methods instead, does that bypass the macro issue?
>
> Paul Brett wrote:
> No, that doesn't work. At the calling site, x.major() gets expanded to x.gnu_dev_major() by the macro.
>
> Kapil Arya wrote:
> Can we just `#undef` the macros for this file. AFAIK, we aren't using them in the source code.
We could but we would be doing that in a header file which would impact everyone who might ever include stout version directly or indirectly. How about we use getMajor(), getMinor() and getPatch() accessor methods?
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36336/#review91047
-----------------------------------------------------------
On July 8, 2015, 10:50 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36336/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 10:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-3020
> https://issues.apache.org/jira/browse/MESOS-3020
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Expose major, minor and patch components from stout Version
>
> Note: The names major and minor are not available when compiling with GCC because it pulls in the sysmacros.h header implicitly which define these for makedev.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 8692323d28131cd5706dde0503d49f8f0b0a1aeb
>
> Diff: https://reviews.apache.org/r/36336/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 36336: Expose major,
minor and patch components from stout Version
Posted by Paul Brett <pa...@twopensource.com>.
> On July 9, 2015, 2:46 a.m., Kapil Arya wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, line 36
> > <https://reviews.apache.org/r/36336/diff/1/?file=1002978#file1002978line36>
> >
> > Why do we want to rename major/minor/patch to primary/secondary/tertiary? The former is a widely accepted format.
>
> Paul Brett wrote:
> g++ defines _GNU_SOURCE (required for libstdc++). This #includes sysmacros.h which #define major and minor as macros for makedev.
>
> Ben Mahler wrote:
> If you add major(), minor(), patch() as methods instead, does that bypass the macro issue?
No, that doesn't work. At the calling site, x.major() gets expanded to x.gnu_dev_major() by the macro.
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36336/#review91047
-----------------------------------------------------------
On July 8, 2015, 10:50 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36336/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 10:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-3020
> https://issues.apache.org/jira/browse/MESOS-3020
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Expose major, minor and patch components from stout Version
>
> Note: The names major and minor are not available when compiling with GCC because it pulls in the sysmacros.h header implicitly which define these for makedev.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 8692323d28131cd5706dde0503d49f8f0b0a1aeb
>
> Diff: https://reviews.apache.org/r/36336/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 36336: Expose major,
minor and patch components from stout Version
Posted by Paul Brett <pa...@twopensource.com>.
> On July 9, 2015, 2:46 a.m., Kapil Arya wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, line 36
> > <https://reviews.apache.org/r/36336/diff/1/?file=1002978#file1002978line36>
> >
> > Why do we want to rename major/minor/patch to primary/secondary/tertiary? The former is a widely accepted format.
g++ defines _GNU_SOURCE (required for libstdc++). This #includes sysmacros.h which #define major and minor as macros for makedev.
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36336/#review91047
-----------------------------------------------------------
On July 8, 2015, 10:50 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36336/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 10:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-3020
> https://issues.apache.org/jira/browse/MESOS-3020
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Expose major, minor and patch components from stout Version
>
> Note: The names major and minor are not available when compiling with GCC because it pulls in the sysmacros.h header implicitly which define these for makedev.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 8692323d28131cd5706dde0503d49f8f0b0a1aeb
>
> Diff: https://reviews.apache.org/r/36336/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 36336: Expose major,
minor and patch components from stout Version
Posted by Ben Mahler <be...@gmail.com>.
> On July 9, 2015, 2:46 a.m., Kapil Arya wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, line 36
> > <https://reviews.apache.org/r/36336/diff/1/?file=1002978#file1002978line36>
> >
> > Why do we want to rename major/minor/patch to primary/secondary/tertiary? The former is a widely accepted format.
>
> Paul Brett wrote:
> g++ defines _GNU_SOURCE (required for libstdc++). This #includes sysmacros.h which #define major and minor as macros for makedev.
>
> Ben Mahler wrote:
> If you add major(), minor(), patch() as methods instead, does that bypass the macro issue?
>
> Paul Brett wrote:
> No, that doesn't work. At the calling site, x.major() gets expanded to x.gnu_dev_major() by the macro.
>
> Kapil Arya wrote:
> Can we just `#undef` the macros for this file. AFAIK, we aren't using them in the source code.
>
> Paul Brett wrote:
> We could but we would be doing that in a header file which would impact everyone who might ever include stout version directly or indirectly. How about we use getMajor(), getMinor() and getPatch() accessor methods?
Per our chat, how about majorVersion(), minorVersion(), patchVersion() with a note for posterity?
With getMajor(), seems callers might still be likely to call their variable 'major': `unsigned int major = version.getMajor()`
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36336/#review91047
-----------------------------------------------------------
On July 8, 2015, 10:50 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36336/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 10:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-3020
> https://issues.apache.org/jira/browse/MESOS-3020
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Expose major, minor and patch components from stout Version
>
> Note: The names major and minor are not available when compiling with GCC because it pulls in the sysmacros.h header implicitly which define these for makedev.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 8692323d28131cd5706dde0503d49f8f0b0a1aeb
>
> Diff: https://reviews.apache.org/r/36336/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 36336: Expose major,
minor and patch components from stout Version
Posted by Kapil Arya <ka...@mesosphere.io>.
> On July 8, 2015, 10:46 p.m., Kapil Arya wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp, line 36
> > <https://reviews.apache.org/r/36336/diff/1/?file=1002978#file1002978line36>
> >
> > Why do we want to rename major/minor/patch to primary/secondary/tertiary? The former is a widely accepted format.
>
> Paul Brett wrote:
> g++ defines _GNU_SOURCE (required for libstdc++). This #includes sysmacros.h which #define major and minor as macros for makedev.
>
> Ben Mahler wrote:
> If you add major(), minor(), patch() as methods instead, does that bypass the macro issue?
>
> Paul Brett wrote:
> No, that doesn't work. At the calling site, x.major() gets expanded to x.gnu_dev_major() by the macro.
Can we just `#undef` the macros for this file. AFAIK, we aren't using them in the source code.
- Kapil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36336/#review91047
-----------------------------------------------------------
On July 8, 2015, 6:50 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36336/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 6:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-3020
> https://issues.apache.org/jira/browse/MESOS-3020
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Expose major, minor and patch components from stout Version
>
> Note: The names major and minor are not available when compiling with GCC because it pulls in the sysmacros.h header implicitly which define these for makedev.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 8692323d28131cd5706dde0503d49f8f0b0a1aeb
>
> Diff: https://reviews.apache.org/r/36336/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 36336: Expose major,
minor and patch components from stout Version
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36336/#review91047
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp (line 35)
<https://reviews.apache.org/r/36336/#comment144301>
Why do we want to rename major/minor/patch to primary/secondary/tertiary? The former is a widely accepted format.
- Kapil Arya
On July 8, 2015, 6:50 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36336/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 6:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-3020
> https://issues.apache.org/jira/browse/MESOS-3020
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Expose major, minor and patch components from stout Version
>
> Note: The names major and minor are not available when compiling with GCC because it pulls in the sysmacros.h header implicitly which define these for makedev.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 8692323d28131cd5706dde0503d49f8f0b0a1aeb
>
> Diff: https://reviews.apache.org/r/36336/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 36336: Expose major,
minor and patch components from stout Version
Posted by Paul Brett <pa...@twopensource.com>.
> On July 8, 2015, 11:44 p.m., Vinod Kone wrote:
> > Are you sure we cannot use major, minor and patch? How come we havent encountered an issue so far?
They are private member variables with no accessors. Previously, we just used the comparison operations built into the Version class but these will give the wrong results for installations where the 3.x kernels have been renamed as 2.6.40+x to avoid some legacy compatability bugs.
- Paul
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36336/#review91023
-----------------------------------------------------------
On July 8, 2015, 10:50 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36336/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 10:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-3020
> https://issues.apache.org/jira/browse/MESOS-3020
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Expose major, minor and patch components from stout Version
>
> Note: The names major and minor are not available when compiling with GCC because it pulls in the sysmacros.h header implicitly which define these for makedev.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 8692323d28131cd5706dde0503d49f8f0b0a1aeb
>
> Diff: https://reviews.apache.org/r/36336/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 36336: Expose major,
minor and patch components from stout Version
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36336/#review91023
-----------------------------------------------------------
Are you sure we cannot use major, minor and patch? How come we havent encountered an issue so far?
- Vinod Kone
On July 8, 2015, 10:50 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36336/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 10:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-3020
> https://issues.apache.org/jira/browse/MESOS-3020
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Expose major, minor and patch components from stout Version
>
> Note: The names major and minor are not available when compiling with GCC because it pulls in the sysmacros.h header implicitly which define these for makedev.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 8692323d28131cd5706dde0503d49f8f0b0a1aeb
>
> Diff: https://reviews.apache.org/r/36336/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 36336: Expose major,
minor and patch components from stout Version
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36336/#review91058
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36336]
All tests passed.
- Mesos ReviewBot
On July 8, 2015, 10:50 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36336/
> -----------------------------------------------------------
>
> (Updated July 8, 2015, 10:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-3020
> https://issues.apache.org/jira/browse/MESOS-3020
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Expose major, minor and patch components from stout Version
>
> Note: The names major and minor are not available when compiling with GCC because it pulls in the sysmacros.h header implicitly which define these for makedev.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 8692323d28131cd5706dde0503d49f8f0b0a1aeb
>
> Diff: https://reviews.apache.org/r/36336/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 36336: Expose major,
minor and patch components from stout Version
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36336/#review91218
-----------------------------------------------------------
Ship it!
Thanks for adding the note Paul! Surprised that these are 'int's rather than 'unsigned int's.
- Ben Mahler
On July 9, 2015, 10:06 p.m., Paul Brett wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36336/
> -----------------------------------------------------------
>
> (Updated July 9, 2015, 10:06 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, Kapil Arya, and Vinod Kone.
>
>
> Bugs: MESOS-3020
> https://issues.apache.org/jira/browse/MESOS-3020
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Expose major, minor and patch components from stout Version
>
> Note: The names major and minor are not available when compiling with GCC because it pulls in the sysmacros.h header implicitly which define these for makedev.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 8692323d28131cd5706dde0503d49f8f0b0a1aeb
>
> Diff: https://reviews.apache.org/r/36336/diff/
>
>
> Testing
> -------
>
> sudo make check
>
>
> Thanks,
>
> Paul Brett
>
>
Re: Review Request 36336: Expose major,
minor and patch components from stout Version
Posted by Paul Brett <pa...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36336/
-----------------------------------------------------------
(Updated July 9, 2015, 10:06 p.m.)
Review request for mesos, Benjamin Hindman, Ben Mahler, Ian Downes, Jie Yu, Kapil Arya, and Vinod Kone.
Changes
-------
Incorporate review comments.
Bugs: MESOS-3020
https://issues.apache.org/jira/browse/MESOS-3020
Repository: mesos
Description
-------
Expose major, minor and patch components from stout Version
Note: The names major and minor are not available when compiling with GCC because it pulls in the sysmacros.h header implicitly which define these for makedev.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp 8692323d28131cd5706dde0503d49f8f0b0a1aeb
Diff: https://reviews.apache.org/r/36336/diff/
Testing
-------
sudo make check
Thanks,
Paul Brett