You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by yinonavraham <gi...@git.apache.org> on 2017/10/25 11:03:25 UTC
[GitHub] incubator-weex pull request #822: Remove maven central repository, use only ...
GitHub user yinonavraham opened a pull request:
https://github.com/apache/incubator-weex/pull/822
Remove maven central repository, use only jcenter
jcenter is a super set on top of maven central, so having both of those repositories is redundant, and the preferred one should be jcenter.
CheckList:
* [x] Update API docs for the component.
* [x] Update/Add demo to demonstrate new feature.
* [x] Update test scripts for the feature.
* [x] Add unit tests for the feature.
(checked, although not really relevant - not a feature nor bug...)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/yinonavraham/incubator-weex patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/822.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #822
----
commit d4277ee79367536bc36e8bc3d1d412524cf254fa
Author: Yinon Avraham <yi...@gmail.com>
Date: 2017-10-25T11:00:06Z
Remove maven central repository, use only jcenter
jcenter is a super set on top of maven central, so having both of those repositories is redundant, and the preferred one should be jcenter.
----
---
[GitHub] incubator-weex issue #822: Remove maven central repository, use only jcenter
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/822
<!--
0 failure:
0 warning:
2 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>has no jsfm file changed.</td>
</tr>
<tr>
<td>:book:</td>
<td>jsfm test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
[GitHub] incubator-weex pull request #822: Remove maven central repository, use only ...
Posted by misakuo <gi...@git.apache.org>.
Github user misakuo commented on a diff in the pull request:
https://github.com/apache/incubator-weex/pull/822#discussion_r152212531
--- Diff: android/build.gradle ---
@@ -1,7 +1,6 @@
buildscript {
repositories {
- mavenCentral()
--- End diff --
Replace it with `mavenLocal`
---
[GitHub] incubator-weex issue #822: Remove maven central repository, use only jcenter
Posted by yinonavraham <gi...@git.apache.org>.
Github user yinonavraham commented on the issue:
https://github.com/apache/incubator-weex/pull/822
Ah, sure, that's ok, sorry for the misunderstanding. I think it is implicit, but it's ok to have it anyway.
---
[GitHub] incubator-weex issue #822: Remove maven central repository, use only jcenter
Posted by misakuo <gi...@git.apache.org>.
Github user misakuo commented on the issue:
https://github.com/apache/incubator-weex/pull/822
I mean
```groovy
repositories {
mavenLocal()
jcenter()
}
```
First find in the local maven cache, if not found, find in jcenter
---
[GitHub] incubator-weex pull request #822: Remove maven central repository, use only ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/822
---
[GitHub] incubator-weex issue #822: Remove maven central repository, use only jcenter
Posted by misakuo <gi...@git.apache.org>.
Github user misakuo commented on the issue:
https://github.com/apache/incubator-weex/pull/822
Thanks for your contribution. we can remove the `mavenCentral` from repositories, but I think to replace it with `mavenLocal` will be better?
---
[GitHub] incubator-weex issue #822: Remove maven central repository, use only jcenter
Posted by yinonavraham <gi...@git.apache.org>.
Github user yinonavraham commented on the issue:
https://github.com/apache/incubator-weex/pull/822
Certainly not. `mavenLocal` is your local maven cache (i.e. the `.m2` directory). Doing so will remove any central maven repository. You should at least have either `jcenter` or `mavenCentral`, I defenetly prefer `jcenter`.
---