[jira] [Work logged] (BEAM-9841) PortableRunner does not support wait_until_finish(duration=...)

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/BEAM-9841?focusedWorklogId=429815&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-429815 ]

ASF GitHub Bot logged work on BEAM-9841:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/May/20 11:34
            Start Date: 02/May/20 11:34
    Worklog Time Spent: 10m 
      Work Description: mxm commented on a change in pull request #11556:
URL: https://github.com/apache/beam/pull/11556#discussion_r418947573



##########
File path: sdks/python/apache_beam/runners/portability/portable_runner.py
##########
@@ -535,7 +537,7 @@ def _last_error_message(self):
     else:
       return 'unknown error'
 
-  def wait_until_finish(self):
+  def wait_until_finish(self, duration=None):

Review comment:
       Agree that the parameter name/default is not optimally chosen. Added a docstring.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 429815)
    Time Spent: 0.5h  (was: 20m)

> PortableRunner does not support wait_until_finish(duration=...)
> ---------------------------------------------------------------
>
>                 Key: BEAM-9841
>                 URL: https://issues.apache.org/jira/browse/BEAM-9841
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Other runners in the Python SDK support waiting for a finite amount of time on the PipelineResult, and so should PortableRunner.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)