You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/04/30 18:39:07 UTC
[GitHub] [netbeans] BradWalker opened a new pull request #2114: [NETBEANS-4284] - cleanup a bunch of raw type warnings..
BradWalker opened a new pull request #2114:
URL: https://github.com/apache/netbeans/pull/2114
Cleanup a bunch of raw type warnings related to the following..
[repeat] /home/bwalker/src/netbeans/platform/openide.util/src/org/openide/util/MapFormat.java:91: warning: [rawtypes] found raw type: Map
[repeat] public MapFormat(Map arguments) {
[repeat] ^
[repeat] missing type arguments for generic class Map<K,V>
[repeat] where K,V are type-variables:
[repeat] K extends Object declared in interface Map
[repeat] V extends Object declared in interface Map
[repeat] /home/bwalker/src/netbeans/platform/openide.util/src/org/openide/util/MapFormat.java:105: warning: [rawtypes]
Also, updated Iterator raw types warnings..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #2114: [NETBEANS-4284] - cleanup a bunch of raw type warnings..
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #2114:
URL: https://github.com/apache/netbeans/pull/2114
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing merged pull request #2114: [NETBEANS-4284] - cleanup a bunch of raw type warnings..
Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged pull request #2114:
URL: https://github.com/apache/netbeans/pull/2114
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2114: [NETBEANS-4284] - cleanup a bunch of raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2114:
URL: https://github.com/apache/netbeans/pull/2114#discussion_r492375640
##########
File path: ide/xml/src/org/netbeans/modules/xml/actions/CollectSystemAction.java
##########
@@ -44,7 +44,7 @@
/** empty array of menu items */
static JMenuItem[] NONE = new JMenuItem[] {};
- protected final List registeredAction = new ArrayList();
+ protected final List<Object> registeredAction = new ArrayList<>();
Review comment:
Hey @matthiasblaesing , fixed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2114: [NETBEANS-4284] - cleanup a bunch of raw type warnings..
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2114:
URL: https://github.com/apache/netbeans/pull/2114#issuecomment-696894795
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #2114: [NETBEANS-4284] - cleanup a bunch of raw type warnings..
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on pull request #2114:
URL: https://github.com/apache/netbeans/pull/2114#issuecomment-696894795
Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2114: [NETBEANS-4284] - cleanup a bunch of raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2114:
URL: https://github.com/apache/netbeans/pull/2114#discussion_r492375640
##########
File path: ide/xml/src/org/netbeans/modules/xml/actions/CollectSystemAction.java
##########
@@ -44,7 +44,7 @@
/** empty array of menu items */
static JMenuItem[] NONE = new JMenuItem[] {};
- protected final List registeredAction = new ArrayList();
+ protected final List<Object> registeredAction = new ArrayList<>();
Review comment:
Hey @matthiasblaesing , fixed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2114: [NETBEANS-4284] - cleanup a bunch of raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2114:
URL: https://github.com/apache/netbeans/pull/2114#discussion_r449985353
##########
File path: java/maven.grammar/src/org/netbeans/modules/maven/codegen/ExclusionGenerator.java
##########
@@ -90,9 +90,9 @@ public int write() {
// now check the active profiles for the dependency..
List<String> profileNames = new ArrayList<String>();
NbMavenProject project = prj.getLookup().lookup(NbMavenProject.class);
- Iterator it = project.getMavenProject().getActiveProfiles().iterator();
+ Iterator<org.apache.maven.model.Profile> it = project.getMavenProject().getActiveProfiles().iterator();
Review comment:
Hey @hectorespert , I wish I could do this.. But, there is already another Profile class being used, org.netbeans.modules.maven.model.pom.Profile. And it's not easy to distinguish between the two..
So we're going to have to leave this one alone..
Thanks for the feedback and hopefully you can now approve it for 12.1..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2114: [NETBEANS-4284] - cleanup a bunch of raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2114:
URL: https://github.com/apache/netbeans/pull/2114#discussion_r492375640
##########
File path: ide/xml/src/org/netbeans/modules/xml/actions/CollectSystemAction.java
##########
@@ -44,7 +44,7 @@
/** empty array of menu items */
static JMenuItem[] NONE = new JMenuItem[] {};
- protected final List registeredAction = new ArrayList();
+ protected final List<Object> registeredAction = new ArrayList<>();
Review comment:
Hey @matthiasblaesing , fixed..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2114: [NETBEANS-4284] - cleanup a bunch of raw type warnings..
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2114:
URL: https://github.com/apache/netbeans/pull/2114#discussion_r487429590
##########
File path: ide/projectuiapi/src/org/netbeans/spi/project/ui/support/NodeFactorySupport.java
##########
@@ -174,7 +174,7 @@ public void run() {
NodeList<?> lst = factory.createNodes(project);
assert lst != null : "Factory " + factory.getClass() + " has broken the NodeFactory contract."; //NOI18N
lst.addNotify();
- List<?> objects = lst.keys();
+ List objects = lst.keys();
Review comment:
Is the switch to raw types here intented? This looks strange given the target of this PR.
##########
File path: ide/projectuiapi/src/org/netbeans/spi/project/ui/support/NodeFactorySupport.java
##########
@@ -174,7 +174,7 @@ public void run() {
NodeList<?> lst = factory.createNodes(project);
assert lst != null : "Factory " + factory.getClass() + " has broken the NodeFactory contract."; //NOI18N
lst.addNotify();
- List<?> objects = lst.keys();
+ List objects = lst.keys();
Review comment:
Is the switch to raw types here intented? This looks strange given the target of this PR.
##########
File path: ide/projectuiapi/src/org/netbeans/spi/project/ui/support/NodeFactorySupport.java
##########
@@ -174,7 +174,7 @@ public void run() {
NodeList<?> lst = factory.createNodes(project);
assert lst != null : "Factory " + factory.getClass() + " has broken the NodeFactory contract."; //NOI18N
lst.addNotify();
- List<?> objects = lst.keys();
+ List objects = lst.keys();
Review comment:
Is the switch to raw types here intented? This looks strange given the target of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2114: [NETBEANS-4284] - cleanup a bunch of raw type warnings..
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2114:
URL: https://github.com/apache/netbeans/pull/2114#discussion_r490899705
##########
File path: ide/xml/src/org/netbeans/modules/xml/actions/CollectSystemAction.java
##########
@@ -44,7 +44,7 @@
/** empty array of menu items */
static JMenuItem[] NONE = new JMenuItem[] {};
- protected final List registeredAction = new ArrayList();
+ protected final List<Object> registeredAction = new ArrayList<>();
Review comment:
This is API (exported package, the member is protected, so visible from the outside).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2114: [NETBEANS-4284] - cleanup a bunch of raw type warnings..
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2114:
URL: https://github.com/apache/netbeans/pull/2114#discussion_r487429590
##########
File path: ide/projectuiapi/src/org/netbeans/spi/project/ui/support/NodeFactorySupport.java
##########
@@ -174,7 +174,7 @@ public void run() {
NodeList<?> lst = factory.createNodes(project);
assert lst != null : "Factory " + factory.getClass() + " has broken the NodeFactory contract."; //NOI18N
lst.addNotify();
- List<?> objects = lst.keys();
+ List objects = lst.keys();
Review comment:
Is the switch to raw types here intented? This looks strange given the target of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] BradWalker commented on a change in pull request #2114: [NETBEANS-4284] - cleanup a bunch of raw type warnings..
Posted by GitBox <gi...@apache.org>.
BradWalker commented on a change in pull request #2114:
URL: https://github.com/apache/netbeans/pull/2114#discussion_r490603067
##########
File path: ide/projectuiapi/src/org/netbeans/spi/project/ui/support/NodeFactorySupport.java
##########
@@ -174,7 +174,7 @@ public void run() {
NodeList<?> lst = factory.createNodes(project);
assert lst != null : "Factory " + factory.getClass() + " has broken the NodeFactory contract."; //NOI18N
lst.addNotify();
- List<?> objects = lst.keys();
+ List objects = lst.keys();
Review comment:
I've reverted the file NodeFactorySupport.java to the original.. It was too problematic to fix.. Will clean up later as there's plenty to do..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2114: [NETBEANS-4284] - cleanup a bunch of raw type warnings..
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2114:
URL: https://github.com/apache/netbeans/pull/2114#discussion_r487429590
##########
File path: ide/projectuiapi/src/org/netbeans/spi/project/ui/support/NodeFactorySupport.java
##########
@@ -174,7 +174,7 @@ public void run() {
NodeList<?> lst = factory.createNodes(project);
assert lst != null : "Factory " + factory.getClass() + " has broken the NodeFactory contract."; //NOI18N
lst.addNotify();
- List<?> objects = lst.keys();
+ List objects = lst.keys();
Review comment:
Is the switch to raw types here intented? This looks strange given the target of this PR.
##########
File path: ide/projectuiapi/src/org/netbeans/spi/project/ui/support/NodeFactorySupport.java
##########
@@ -174,7 +174,7 @@ public void run() {
NodeList<?> lst = factory.createNodes(project);
assert lst != null : "Factory " + factory.getClass() + " has broken the NodeFactory contract."; //NOI18N
lst.addNotify();
- List<?> objects = lst.keys();
+ List objects = lst.keys();
Review comment:
Is the switch to raw types here intented? This looks strange given the target of this PR.
##########
File path: ide/projectuiapi/src/org/netbeans/spi/project/ui/support/NodeFactorySupport.java
##########
@@ -174,7 +174,7 @@ public void run() {
NodeList<?> lst = factory.createNodes(project);
assert lst != null : "Factory " + factory.getClass() + " has broken the NodeFactory contract."; //NOI18N
lst.addNotify();
- List<?> objects = lst.keys();
+ List objects = lst.keys();
Review comment:
Is the switch to raw types here intented? This looks strange given the target of this PR.
##########
File path: ide/projectuiapi/src/org/netbeans/spi/project/ui/support/NodeFactorySupport.java
##########
@@ -174,7 +174,7 @@ public void run() {
NodeList<?> lst = factory.createNodes(project);
assert lst != null : "Factory " + factory.getClass() + " has broken the NodeFactory contract."; //NOI18N
lst.addNotify();
- List<?> objects = lst.keys();
+ List objects = lst.keys();
Review comment:
Is the switch to raw types here intented? This looks strange given the target of this PR.
##########
File path: ide/projectuiapi/src/org/netbeans/spi/project/ui/support/NodeFactorySupport.java
##########
@@ -174,7 +174,7 @@ public void run() {
NodeList<?> lst = factory.createNodes(project);
assert lst != null : "Factory " + factory.getClass() + " has broken the NodeFactory contract."; //NOI18N
lst.addNotify();
- List<?> objects = lst.keys();
+ List objects = lst.keys();
Review comment:
Is the switch to raw types here intented? This looks strange given the target of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #2114: [NETBEANS-4284] - cleanup a bunch of raw type warnings..
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #2114:
URL: https://github.com/apache/netbeans/pull/2114#discussion_r487429590
##########
File path: ide/projectuiapi/src/org/netbeans/spi/project/ui/support/NodeFactorySupport.java
##########
@@ -174,7 +174,7 @@ public void run() {
NodeList<?> lst = factory.createNodes(project);
assert lst != null : "Factory " + factory.getClass() + " has broken the NodeFactory contract."; //NOI18N
lst.addNotify();
- List<?> objects = lst.keys();
+ List objects = lst.keys();
Review comment:
Is the switch to raw types here intented? This looks strange given the target of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] hectorespert commented on a change in pull request #2114: [NETBEANS-4284] - cleanup a bunch of raw type warnings..
Posted by GitBox <gi...@apache.org>.
hectorespert commented on a change in pull request #2114:
URL: https://github.com/apache/netbeans/pull/2114#discussion_r449189202
##########
File path: java/maven.grammar/src/org/netbeans/modules/maven/codegen/ExclusionGenerator.java
##########
@@ -90,9 +90,9 @@ public int write() {
// now check the active profiles for the dependency..
List<String> profileNames = new ArrayList<String>();
NbMavenProject project = prj.getLookup().lookup(NbMavenProject.class);
- Iterator it = project.getMavenProject().getActiveProfiles().iterator();
+ Iterator<org.apache.maven.model.Profile> it = project.getMavenProject().getActiveProfiles().iterator();
Review comment:
Why not import this class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists