You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@asterixdb.apache.org by "Pritom Ahmed (Code Review)" <do...@asterixdb.incubator.apache.org> on 2016/02/26 01:00:30 UTC

Change in hyracks[master]: ASTERIXDB-1287: Fixed Admin Console pages.

Hello Steven Jacobs, Jenkins,

I'd like you to reexamine a change.  Please visit

    https://asterix-gerrit.ics.uci.edu/557

to look at the new patch set (#3).

Change subject: ASTERIXDB-1287: Fixed Admin Console pages.
......................................................................

ASTERIXDB-1287: Fixed Admin Console pages.

Previously the job details page of the admin console was not working correctly. Now It is fixed.
Also fixed some internal issues like wrong time shown.

	*    Now JSON data in adminconsole for Job Details is shown in tabular form.
	*    Previously, in job details page of admin console, all the data was shown in raw JSON
format. Now using a MIT licensed js library, it is shown in tabular form.
	*    Added Headers for the data shown in Index page of adminconsole.
	*    Previously in job summary, create time, start time and end time was never updated.
As a result they all were 0. Fixed it.
	*    In adminconsole's Index page, the job create time, start time and end time all were
being assigned with create time. Fixed it. The same problem was also present in the REST API as well.
Also fixed it.
	*    Showing a message in job details page in admin console for jobs that were deleted
because the maximum size of job archive was reached.
	*    Beautified the job details page in adminconsole by adding tabs.
	*    Fixed the job details page in adminconsole. Previously it was broken. Now it shows the
raw JSON data sent to it.
	*    Optimized the node details information sent by the adminconsole API. Previously, the
API was sending the full array everytime even though the whole array was not full. As a result,
there were many instances with no data. Now its sending only the subarrays that actually contains data.

Change-Id: I3944ed0c972f227aa1397d1cf6608f78f5f8c540
---
M hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/NodeControllerState.java
M hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/adminconsole/pages/IndexPage.java
M hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/job/JobRun.java
M hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/scheduler/JobScheduler.java
M hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/GetJobSummariesJSONWork.java
M hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/JobCleanupWork.java
M hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/JobStartWork.java
M hyracks/hyracks-control/hyracks-control-cc/src/main/java/org/apache/hyracks/control/cc/work/JobletCleanupNotificationWork.java
M hyracks/hyracks-control/hyracks-control-cc/src/main/resources/org/apache/hyracks/control/cc/adminconsole/pages/AbstractPage.html
M hyracks/hyracks-control/hyracks-control-cc/src/main/resources/org/apache/hyracks/control/cc/adminconsole/pages/IndexPage.html
M hyracks/hyracks-control/hyracks-control-cc/src/main/resources/org/apache/hyracks/control/cc/adminconsole/pages/JobDetailsPage.html
M hyracks/hyracks-control/hyracks-control-cc/src/main/resources/static/javascript/adminconsole/JobDetailsPage.js
A hyracks/hyracks-control/hyracks-control-cc/src/main/resources/static/javascript/adminconsole/json.human.js
A hyracks/hyracks-control/hyracks-control-cc/src/main/resources/static/stylesheet/json.human.css
M pom.xml
15 files changed, 686 insertions(+), 50 deletions(-)


  git pull ssh://asterix-gerrit.ics.uci.edu:29418/hyracks refs/changes/57/557/3
-- 
To view, visit https://asterix-gerrit.ics.uci.edu/557
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3944ed0c972f227aa1397d1cf6608f78f5f8c540
Gerrit-PatchSet: 3
Gerrit-Project: hyracks
Gerrit-Branch: master
Gerrit-Owner: Pritom Ahmed <pr...@gmail.com>
Gerrit-Reviewer: Ian Maxon <im...@apache.org>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Preston Carman <pr...@apache.org>
Gerrit-Reviewer: Pritom Ahmed <pr...@gmail.com>
Gerrit-Reviewer: Steven Jacobs <sj...@ucr.edu>