You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Matthew Reiter <ma...@hotmail.com> on 2012/06/26 18:06:40 UTC
Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX is
disabled".
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5589/
-----------------------------------------------------------
Review request for shindig.
Description
-------
Code review for my proposed solution to "makeRequest fails on IE when ActiveX is disabled".
This addresses bug SHINDIG-1808.
https://issues.apache.org/jira/browse/SHINDIG-1808
Diffs
-----
/trunk/features/src/main/javascript/features/core.io/io.js 1351826
Diff: https://reviews.apache.org/r/5589/diff/
Testing
-------
Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with ActiveX disabled and IE 9 with ActiveX enabled.
Thanks,
Matthew Reiter
Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX
is disabled".
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5589/#review8679
-----------------------------------------------------------
Ship it!
LGTM. Thanks for going through the work of writing the extra tests. I'll wait another day to give everyone else a chance to review the tests and then I'll commit the patch.
- Stanton Sievers
On June 27, 2012, 10:44 p.m., Matthew Reiter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5589/
> -----------------------------------------------------------
>
> (Updated June 27, 2012, 10:44 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Code review for my proposed solution to "makeRequest fails on IE when ActiveX is disabled".
>
>
> This addresses bug SHINDIG-1808.
> https://issues.apache.org/jira/browse/SHINDIG-1808
>
>
> Diffs
> -----
>
> /trunk/features/src/main/javascript/features/core.io/io.js 1354070
> /trunk/features/src/test/javascript/features/core.io/iotest.js 1354070
>
> Diff: https://reviews.apache.org/r/5589/diff/
>
>
> Testing
> -------
>
> Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with ActiveX disabled and IE 9 with ActiveX enabled.
>
>
> Thanks,
>
> Matthew Reiter
>
>
Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX
is disabled".
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5589/#review8753
-----------------------------------------------------------
Ship it!
Committed revision 1355476. Please close this review.
- Stanton Sievers
On June 27, 2012, 10:44 p.m., Matthew Reiter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5589/
> -----------------------------------------------------------
>
> (Updated June 27, 2012, 10:44 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Code review for my proposed solution to "makeRequest fails on IE when ActiveX is disabled".
>
>
> This addresses bug SHINDIG-1808.
> https://issues.apache.org/jira/browse/SHINDIG-1808
>
>
> Diffs
> -----
>
> /trunk/features/src/main/javascript/features/core.io/io.js 1354070
> /trunk/features/src/test/javascript/features/core.io/iotest.js 1354070
>
> Diff: https://reviews.apache.org/r/5589/diff/
>
>
> Testing
> -------
>
> Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with ActiveX disabled and IE 9 with ActiveX enabled.
>
>
> Thanks,
>
> Matthew Reiter
>
>
Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX
is disabled".
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5589/#review8704
-----------------------------------------------------------
Ship it!
Ship It!
- Ryan Baxter
On June 27, 2012, 10:44 p.m., Matthew Reiter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5589/
> -----------------------------------------------------------
>
> (Updated June 27, 2012, 10:44 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Code review for my proposed solution to "makeRequest fails on IE when ActiveX is disabled".
>
>
> This addresses bug SHINDIG-1808.
> https://issues.apache.org/jira/browse/SHINDIG-1808
>
>
> Diffs
> -----
>
> /trunk/features/src/main/javascript/features/core.io/io.js 1354070
> /trunk/features/src/test/javascript/features/core.io/iotest.js 1354070
>
> Diff: https://reviews.apache.org/r/5589/diff/
>
>
> Testing
> -------
>
> Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with ActiveX disabled and IE 9 with ActiveX enabled.
>
>
> Thanks,
>
> Matthew Reiter
>
>
Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX
is disabled".
Posted by Matthew Reiter <ma...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5589/
-----------------------------------------------------------
(Updated June 27, 2012, 10:44 p.m.)
Review request for shindig.
Changes
-------
Added unit tests.
Description
-------
Code review for my proposed solution to "makeRequest fails on IE when ActiveX is disabled".
This addresses bug SHINDIG-1808.
https://issues.apache.org/jira/browse/SHINDIG-1808
Diffs (updated)
-----
/trunk/features/src/main/javascript/features/core.io/io.js 1354070
/trunk/features/src/test/javascript/features/core.io/iotest.js 1354070
Diff: https://reviews.apache.org/r/5589/diff/
Testing
-------
Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with ActiveX disabled and IE 9 with ActiveX enabled.
Thanks,
Matthew Reiter
Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX
is disabled".
Posted by Matthew Reiter <ma...@hotmail.com>.
> On June 27, 2012, 4:38 p.m., Stanton Sievers wrote:
> > Matt, please update the JIRA with the latest patch and grant ASF license. I'll get this committed once that is done.
I'll add the patch to the bug once the unit tests I've added are approved. Am I correct in assuming that I should use the "Submit Patch" button to do so?
- Matthew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5589/#review8656
-----------------------------------------------------------
On June 27, 2012, 10:44 p.m., Matthew Reiter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5589/
> -----------------------------------------------------------
>
> (Updated June 27, 2012, 10:44 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Code review for my proposed solution to "makeRequest fails on IE when ActiveX is disabled".
>
>
> This addresses bug SHINDIG-1808.
> https://issues.apache.org/jira/browse/SHINDIG-1808
>
>
> Diffs
> -----
>
> /trunk/features/src/main/javascript/features/core.io/io.js 1354070
> /trunk/features/src/test/javascript/features/core.io/iotest.js 1354070
>
> Diff: https://reviews.apache.org/r/5589/diff/
>
>
> Testing
> -------
>
> Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with ActiveX disabled and IE 9 with ActiveX enabled.
>
>
> Thanks,
>
> Matthew Reiter
>
>
Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX
is disabled".
Posted by Stanton Sievers <si...@gmail.com>.
> On June 27, 2012, 4:38 p.m., Stanton Sievers wrote:
> > Matt, please update the JIRA with the latest patch and grant ASF license. I'll get this committed once that is done.
>
> Matthew Reiter wrote:
> I'll add the patch to the bug once the unit tests I've added are approved. Am I correct in assuming that I should use the "Submit Patch" button to do so?
"Submit Patch" is misleading. To attach the patch please use the More Actions -> Attach Files menu.
- Stanton
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5589/#review8656
-----------------------------------------------------------
On June 27, 2012, 10:44 p.m., Matthew Reiter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5589/
> -----------------------------------------------------------
>
> (Updated June 27, 2012, 10:44 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Code review for my proposed solution to "makeRequest fails on IE when ActiveX is disabled".
>
>
> This addresses bug SHINDIG-1808.
> https://issues.apache.org/jira/browse/SHINDIG-1808
>
>
> Diffs
> -----
>
> /trunk/features/src/main/javascript/features/core.io/io.js 1354070
> /trunk/features/src/test/javascript/features/core.io/iotest.js 1354070
>
> Diff: https://reviews.apache.org/r/5589/diff/
>
>
> Testing
> -------
>
> Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with ActiveX disabled and IE 9 with ActiveX enabled.
>
>
> Thanks,
>
> Matthew Reiter
>
>
Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX
is disabled".
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5589/#review8656
-----------------------------------------------------------
Matt, please update the JIRA with the latest patch and grant ASF license. I'll get this committed once that is done.
- Stanton Sievers
On June 26, 2012, 5:59 p.m., Matthew Reiter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5589/
> -----------------------------------------------------------
>
> (Updated June 26, 2012, 5:59 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Code review for my proposed solution to "makeRequest fails on IE when ActiveX is disabled".
>
>
> This addresses bug SHINDIG-1808.
> https://issues.apache.org/jira/browse/SHINDIG-1808
>
>
> Diffs
> -----
>
> /trunk/features/src/main/javascript/features/core.io/io.js 1354070
>
> Diff: https://reviews.apache.org/r/5589/diff/
>
>
> Testing
> -------
>
> Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with ActiveX disabled and IE 9 with ActiveX enabled.
>
>
> Thanks,
>
> Matthew Reiter
>
>
Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX
is disabled".
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5589/#review8615
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Dumont
On June 26, 2012, 5:59 p.m., Matthew Reiter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5589/
> -----------------------------------------------------------
>
> (Updated June 26, 2012, 5:59 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Code review for my proposed solution to "makeRequest fails on IE when ActiveX is disabled".
>
>
> This addresses bug SHINDIG-1808.
> https://issues.apache.org/jira/browse/SHINDIG-1808
>
>
> Diffs
> -----
>
> /trunk/features/src/main/javascript/features/core.io/io.js 1354070
>
> Diff: https://reviews.apache.org/r/5589/diff/
>
>
> Testing
> -------
>
> Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with ActiveX disabled and IE 9 with ActiveX enabled.
>
>
> Thanks,
>
> Matthew Reiter
>
>
Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX
is disabled".
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5589/#review8620
-----------------------------------------------------------
Ship it!
Ship It!
- Stanton Sievers
On June 26, 2012, 5:59 p.m., Matthew Reiter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5589/
> -----------------------------------------------------------
>
> (Updated June 26, 2012, 5:59 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Code review for my proposed solution to "makeRequest fails on IE when ActiveX is disabled".
>
>
> This addresses bug SHINDIG-1808.
> https://issues.apache.org/jira/browse/SHINDIG-1808
>
>
> Diffs
> -----
>
> /trunk/features/src/main/javascript/features/core.io/io.js 1354070
>
> Diff: https://reviews.apache.org/r/5589/diff/
>
>
> Testing
> -------
>
> Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with ActiveX disabled and IE 9 with ActiveX enabled.
>
>
> Thanks,
>
> Matthew Reiter
>
>
Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX
is disabled".
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5589/#review8669
-----------------------------------------------------------
Ship it!
Ship It!
- Ryan Baxter
On June 26, 2012, 5:59 p.m., Matthew Reiter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5589/
> -----------------------------------------------------------
>
> (Updated June 26, 2012, 5:59 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Code review for my proposed solution to "makeRequest fails on IE when ActiveX is disabled".
>
>
> This addresses bug SHINDIG-1808.
> https://issues.apache.org/jira/browse/SHINDIG-1808
>
>
> Diffs
> -----
>
> /trunk/features/src/main/javascript/features/core.io/io.js 1354070
>
> Diff: https://reviews.apache.org/r/5589/diff/
>
>
> Testing
> -------
>
> Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with ActiveX disabled and IE 9 with ActiveX enabled.
>
>
> Thanks,
>
> Matthew Reiter
>
>
Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX
is disabled".
Posted by Matthew Reiter <ma...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5589/
-----------------------------------------------------------
(Updated June 26, 2012, 5:59 p.m.)
Review request for shindig.
Changes
-------
Return a 500 error if there is no DOM parser rather than throwing an exception.
Description
-------
Code review for my proposed solution to "makeRequest fails on IE when ActiveX is disabled".
This addresses bug SHINDIG-1808.
https://issues.apache.org/jira/browse/SHINDIG-1808
Diffs (updated)
-----
/trunk/features/src/main/javascript/features/core.io/io.js 1354070
Diff: https://reviews.apache.org/r/5589/diff/
Testing
-------
Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with ActiveX disabled and IE 9 with ActiveX enabled.
Thanks,
Matthew Reiter
Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX
is disabled".
Posted by Matthew Reiter <ma...@hotmail.com>.
> On June 26, 2012, 5:51 p.m., Dan Dumont wrote:
> > /trunk/features/src/main/javascript/features/core.io/io.js, line 226
> > <https://reviews.apache.org/r/5589/diff/3/?file=116563#file116563line226>
> >
> > I'm not sure that we want to throw here.
> > We should probably be constructing a resp with a error/rc children similar to the error cases above.
Thanks for the feedback. I've updated it to match the other parser errors.
- Matthew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5589/#review8609
-----------------------------------------------------------
On June 26, 2012, 5:59 p.m., Matthew Reiter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5589/
> -----------------------------------------------------------
>
> (Updated June 26, 2012, 5:59 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Code review for my proposed solution to "makeRequest fails on IE when ActiveX is disabled".
>
>
> This addresses bug SHINDIG-1808.
> https://issues.apache.org/jira/browse/SHINDIG-1808
>
>
> Diffs
> -----
>
> /trunk/features/src/main/javascript/features/core.io/io.js 1354070
>
> Diff: https://reviews.apache.org/r/5589/diff/
>
>
> Testing
> -------
>
> Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with ActiveX disabled and IE 9 with ActiveX enabled.
>
>
> Thanks,
>
> Matthew Reiter
>
>
Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX
is disabled".
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5589/#review8609
-----------------------------------------------------------
/trunk/features/src/main/javascript/features/core.io/io.js
<https://reviews.apache.org/r/5589/#comment18261>
I'm not sure that we want to throw here.
We should probably be constructing a resp with a error/rc children similar to the error cases above.
- Dan Dumont
On June 26, 2012, 5:43 p.m., Matthew Reiter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5589/
> -----------------------------------------------------------
>
> (Updated June 26, 2012, 5:43 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Code review for my proposed solution to "makeRequest fails on IE when ActiveX is disabled".
>
>
> This addresses bug SHINDIG-1808.
> https://issues.apache.org/jira/browse/SHINDIG-1808
>
>
> Diffs
> -----
>
> /trunk/features/src/main/javascript/features/core.io/io.js 1354070
>
> Diff: https://reviews.apache.org/r/5589/diff/
>
>
> Testing
> -------
>
> Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with ActiveX disabled and IE 9 with ActiveX enabled.
>
>
> Thanks,
>
> Matthew Reiter
>
>
Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX
is disabled".
Posted by Matthew Reiter <ma...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5589/
-----------------------------------------------------------
(Updated June 26, 2012, 5:43 p.m.)
Review request for shindig.
Changes
-------
Removed extra whitespace.
Description
-------
Code review for my proposed solution to "makeRequest fails on IE when ActiveX is disabled".
This addresses bug SHINDIG-1808.
https://issues.apache.org/jira/browse/SHINDIG-1808
Diffs (updated)
-----
/trunk/features/src/main/javascript/features/core.io/io.js 1354070
Diff: https://reviews.apache.org/r/5589/diff/
Testing
-------
Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with ActiveX disabled and IE 9 with ActiveX enabled.
Thanks,
Matthew Reiter
Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX
is disabled".
Posted by Matthew Reiter <ma...@hotmail.com>.
> On June 26, 2012, 4:57 p.m., Stanton Sievers wrote:
> > Do you know why the exception gets thrown when ActiveX is disabled? ActiveX is disabled yet ActiveXObject != 'undefined'? I didn't see any mention of an exception on the msdn site: http://blogs.msdn.com/b/ie/archive/2011/05/02/activex-filtering-for-developers.aspx
I did see that article and tried checking for ActiveX filtering, but it didn't seem to change anything. I think ActiveX filtering is different from what I was seeing, which was that due to security settings (I was unable to determine exactly which setting was responsible, but adding the website as a trusted site made the exception go away) ActiveX was completely disabled for the website. I do find it strange that the browser claims that ActiveX is supported but then throws an exception any time an ActiveX object is created, but it could just be a limitation of the way it was implemented.
- Matthew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5589/#review8602
-----------------------------------------------------------
On June 26, 2012, 5:43 p.m., Matthew Reiter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5589/
> -----------------------------------------------------------
>
> (Updated June 26, 2012, 5:43 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Code review for my proposed solution to "makeRequest fails on IE when ActiveX is disabled".
>
>
> This addresses bug SHINDIG-1808.
> https://issues.apache.org/jira/browse/SHINDIG-1808
>
>
> Diffs
> -----
>
> /trunk/features/src/main/javascript/features/core.io/io.js 1354070
>
> Diff: https://reviews.apache.org/r/5589/diff/
>
>
> Testing
> -------
>
> Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with ActiveX disabled and IE 9 with ActiveX enabled.
>
>
> Thanks,
>
> Matthew Reiter
>
>
Re: Review Request: Shindig: Fix for "makeRequest fails on IE when ActiveX
is disabled".
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5589/#review8602
-----------------------------------------------------------
Do you know why the exception gets thrown when ActiveX is disabled? ActiveX is disabled yet ActiveXObject != 'undefined'? I didn't see any mention of an exception on the msdn site: http://blogs.msdn.com/b/ie/archive/2011/05/02/activex-filtering-for-developers.aspx
/trunk/features/src/main/javascript/features/core.io/io.js
<https://reviews.apache.org/r/5589/#comment18252>
Small nit on whitespace. Please remove it.
- Stanton Sievers
On June 26, 2012, 4:06 p.m., Matthew Reiter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5589/
> -----------------------------------------------------------
>
> (Updated June 26, 2012, 4:06 p.m.)
>
>
> Review request for shindig.
>
>
> Description
> -------
>
> Code review for my proposed solution to "makeRequest fails on IE when ActiveX is disabled".
>
>
> This addresses bug SHINDIG-1808.
> https://issues.apache.org/jira/browse/SHINDIG-1808
>
>
> Diffs
> -----
>
> /trunk/features/src/main/javascript/features/core.io/io.js 1351826
>
> Diff: https://reviews.apache.org/r/5589/diff/
>
>
> Testing
> -------
>
> Tested makeRequest on Firefox 12, Chrome 20.0.1132.43 beta-m, IE 9 with ActiveX disabled and IE 9 with ActiveX enabled.
>
>
> Thanks,
>
> Matthew Reiter
>
>