[kudu-CR] [ExternalMiniClusterITestBase] move some methods into .cc

["Alexey Serbin (Code Review)" <ge...@cloudera.org>]

Hello Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5367

to look at the new patch set (#3).

Change subject: [ExternalMiniClusterITestBase] move some methods into .cc
......................................................................

[ExternalMiniClusterITestBase] move some methods into .cc

Separated implementation of the external mini-cluster methods into a
separate .cc file: those methods contain too much code to be candidates
for inlining.  Besides, this helps to have less header-wise dependencies
and avoid clang-tidy warnings like

  warning: function 'StopCluster' defined in a header file; function
    definitions in header files can lead to ODR violations
    [misc-definitions-in-headers]

This patch does not contain any functional changes.

Change-Id: I4e69794502d31dc43cc2eba6870c01c828b14da3
---
M src/kudu/integration-tests/CMakeLists.txt
M src/kudu/integration-tests/client_failover-itest.cc
M src/kudu/integration-tests/create-table-itest.cc
M src/kudu/integration-tests/delete_table-test.cc
A src/kudu/integration-tests/external_mini_cluster-itest-base.cc
M src/kudu/integration-tests/external_mini_cluster-itest-base.h
M src/kudu/integration-tests/tablet_replacement-itest.cc
7 files changed, 111 insertions(+), 54 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/5367/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5367
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4e69794502d31dc43cc2eba6870c01c828b14da3
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>