You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2019/01/15 13:29:00 UTC

[jira] [Commented] (AIRFLOW-3709) Validate `allowed_states` for ExternalTaskSensor

    [ https://issues.apache.org/jira/browse/AIRFLOW-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16743054#comment-16743054 ] 

ASF GitHub Bot commented on AIRFLOW-3709:
-----------------------------------------

XD-DENG commented on pull request #4536: [AIRFLOW-3709] Validate `allowed_states` for ExternalTaskSensor
URL: https://github.com/apache/airflow/pull/4536
 
 
   ### Jira
   
     - https://issues.apache.org/jira/browse/AIRFLOW-3709
   
   
   ### Description
   
   In `ExternalTaskSensor`, we can specify `allowed_states`. This commit adds validation for it, so that users will not specify any invalid state (by accident).
   
   This change works no matter the sensor waits for a DAG (available since https://github.com/apache/airflow/commit/2a8c91b392fca53fdc6f7c5008577a7ed4007de7) or a specific task.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   Tests are added.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Validate `allowed_states` for ExternalTaskSensor
> ------------------------------------------------
>
>                 Key: AIRFLOW-3709
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3709
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: operators
>    Affects Versions: 1.10.1
>            Reporter: Xiaodong DENG
>            Assignee: Xiaodong DENG
>            Priority: Minor
>
> In ExternalTaskSensor, we can specify `allowed_states`. We should validate it, so that users will not specify any invalid state.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)