[GitHub] gianm commented on issue #6915: Dependencies are included too many times

[GitBox <gi...@apache.org>]

gianm commented on issue #6915: Dependencies are included too many times
URL: https://github.com/apache/incubator-druid/issues/6915#issuecomment-457963331
 
 
   Maybe we could add some verification step to `distribution` that runs something like this and makes sure we don't have two copies of any jars that appear in `lib`. I'm not sure what to do about jars that only appear in extensions. There are valid reasons to have duplicate versions there: if a jar is not in core, then any extension that needs it has to bundle it. And they could even have different versions if they wanted. `kafka-clients` is a good example: `druid-kafka-eight` and `druid-kafka-indexing-service` have different versions on purpose.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org