[GitHub] [orc] dongjoon-hyun commented on a change in pull request #736: ORC-831: Do Not Copy String When Flushing Dictionary

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #736:
URL: https://github.com/apache/orc/pull/736#discussion_r689158964



##########
File path: java/core/src/java/org/apache/orc/impl/DictionaryUtils.java
##########
@@ -42,4 +44,29 @@ public static void getTextInternal(Text result, int position, DynamicIntArray ke
     }
     byteArray.setText(result, offset, length);
   }
+
+  /**
+   * Write a UTF8 string from the byteArray, using the offset in index-array,
+   * into an OutputStream
+   *
+   * @param out the output stream
+   * @param position position in the keyOffsets
+   * @param keyOffsets starting offset of the key (in byte) in the byte array
+   * @param byteArray storing raw bytes of all keys seen in dictionary
+   * @return the number of bytes written to the output stream
+   * @throw IOException if an I/O error occurs

Review comment:
       Unfortunately, this breaks our `Javadoc` generation. Here is the fix.
   - https://github.com/apache/orc/pull/867




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org