[jira] [Commented] (S2GRAPH-225) support custom udf class

["DOYUNG YOON (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/S2GRAPH-225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16707151#comment-16707151 ] 

DOYUNG YOON commented on S2GRAPH-225:
-------------------------------------

[~chul] I am wondering if this is ready to merge(It seems like).

One quick question on interface.

{noformat}
trait Udf extends Serializable with Logger {
  def register(ss: SparkSession, name:String, options:Map[String, String])
}
{noformat}

Any reason for value in `options` parameter to be `String`? What if some UDF requires primitive types like integer, boolean then should be typecast on each UDF implementation?

> support custom udf class
> ------------------------
>
>                 Key: S2GRAPH-225
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-225
>             Project: S2Graph
>          Issue Type: Sub-task
>          Components: s2jobs
>            Reporter: Chul Kang
>            Assignee: Chul Kang
>            Priority: Minor
>
> We need to support custom UDFs that is available on SQL queries.
> UDFs allow enabling new functions in SQL by abstracting their lower level language implementations. 
> Spark SQL offers integrating custom udf easily.
> I think it would be nice to provide an interface to register the custom UDFs in the Job Description.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)