[jira] [Comment Edited] (KAFKA-1549) dead brokers coming in the TopicMetadataResponse

["nicu marasoiu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066784#comment-14066784 ] 

nicu marasoiu edited comment on KAFKA-1549 at 7/19/14 11:41 AM:
----------------------------------------------------------------

essentially i will replace the map of brokers every update. this will allow for the structure to be immutable likely. however the code does not depend on it and toMap is called on the read side as well, to convert to immutable if needed in the read locked window


was (Author: nmarasoi):
esepntially i will replace the list/map of brokers every update. this will allow for the structure to be immutable likely.

> dead brokers coming in the TopicMetadataResponse
> ------------------------------------------------
>
>                 Key: KAFKA-1549
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1549
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.8.2
>         Environment: trunk
>            Reporter: nicu marasoiu
>            Assignee: Jun Rao
>         Attachments: KAFKA-1549__dead_brokers_coming_in_the_TopicMetadataResponse_.patch
>
>
> JunRao confirming my observation that brokers are only added to the metadataCache, never removed: "The way that we update liveBrokers in MetadataCache.updateCache() doesn't seem right. We only add newly received live brokers to the list. However, there could be existing brokers in that list that are now dead. Those dead brokers shouldn't be returned to the clients. We should probably just take the new live broker list and cache it."



--
This message was sent by Atlassian JIRA
(v6.2#6252)