You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hans Duedal (JIRA)" <ji...@apache.org> on 2011/09/22 15:28:26 UTC
[jira] [Created] (THRIFT-1352) Thrift server
Thrift server
--------------
Key: THRIFT-1352
URL: https://issues.apache.org/jira/browse/THRIFT-1352
Project: Thrift
Issue Type: Improvement
Components: Node.js - Library
Affects Versions: 0.7
Reporter: Hans Duedal
Fix For: 0.8
If a thrift level protocol error occurs. For instance one makes a few changes to the thrift IDL file and a client connects using the old API an unhandled exception can be thrown from the TBinaryProtocol class. By adding a try-catch to the process() call these errors can be caught, the connection closed, and an error event emitted.
Likewise if a client closes the socket, ie. due to a timeout condition, another unhandled exception is thrown from stream.write().
Patch/Pull-request: https://github.com/wadey/node-thrift/pull/16
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1352) Thrift server
Posted by "Jake Farrell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465544#comment-13465544 ]
Jake Farrell commented on THRIFT-1352:
--------------------------------------
Hans, thank you for the work on this issue. We currently do not accept pull requests and ask that you submit a patch attached to this ticket. Please see http://thrift.apache.org/docs/HowToContribute/ for information on this. Thanks
> Thrift server
> --------------
>
> Key: THRIFT-1352
> URL: https://issues.apache.org/jira/browse/THRIFT-1352
> Project: Thrift
> Issue Type: Improvement
> Components: Node.js - Library
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Labels: node, nodejs
>
> If a thrift level protocol error occurs. For instance one makes a few changes to the thrift IDL file and a client connects using the old API an unhandled exception can be thrown from the TBinaryProtocol class. By adding a try-catch to the process() call these errors can be caught, the connection closed, and an error event emitted.
> Likewise if a client closes the socket, ie. due to a timeout condition, another unhandled exception is thrown from stream.write().
> Patch/Pull-request: https://github.com/wadey/node-thrift/pull/16
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira