You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/15 02:26:44 UTC

[GitHub] [pulsar] Anonymitaet commented on a change in pull request #10911: [Docs] Clarify ledger rollover criteria: address size and min time

Anonymitaet commented on a change in pull request #10911:
URL: https://github.com/apache/pulsar/pull/10911#discussion_r651401656



##########
File path: conf/broker.conf
##########
@@ -892,10 +892,11 @@ managedLedgerCursorBackloggedThreshold=1000
 managedLedgerDefaultMarkDeleteRateLimit=1.0
 
 # Max number of entries to append to a ledger before triggering a rollover
-# A ledger rollover is triggered on these conditions
-#  * Either the max rollover time has been reached
-#  * or max entries have been written to the ledger and at least min-time
-#    has passed
+# A ledger rollover is triggered after the min rollover time has passed
+# and one of the following conditions is true:

Review comment:
       double check: `and` or `or`?
   
   `and` means it must meet two conditions (for example, `after the min rollover time has passed` and `The max rollover time has been reached`), then a ledger rollover is triggered.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org