You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Ertl (JIRA)" <ji...@apache.org> on 2008/08/24 11:01:44 UTC

[jira] Created: (WICKET-1799) wicket-extensions has unused reference to commons-collections.jar

wicket-extensions has unused reference to commons-collections.jar
-----------------------------------------------------------------

                 Key: WICKET-1799
                 URL: https://issues.apache.org/jira/browse/WICKET-1799
             Project: Wicket
          Issue Type: Bug
          Components: wicket-extensions
            Reporter: Peter Ertl


It seems that wicket-extensions (both 1.3 and 1.4) holds an unused reference to common-collections.jar in it's pom.xml. 

  <dependency>
    <groupId>commons-collections</groupId>
    <artifactId>commons-collections</artifactId>
  </dependency>

I removed that reference and could still compile everything without any error. Could someone double-check that and remove it if it's really not needed. this would save us from another 570 kb :-)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WICKET-1799) wicket-extensions has unused reference to commons-collections.jar

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635158#action_12635158 ] 

pete edited comment on WICKET-1799 at 9/27/08 8:14 AM:
-------------------------------------------------------------

for 1.3 the pom.xml is correct, however in 1.4.x the reference is still in there.

      was (Author: pete):
    for 1.4 the pom.xml is correct, however in 1.3.x the reference is still in there.
  
> wicket-extensions has unused reference to commons-collections.jar
> -----------------------------------------------------------------
>
>                 Key: WICKET-1799
>                 URL: https://issues.apache.org/jira/browse/WICKET-1799
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>            Reporter: Peter Ertl
>            Assignee: Igor Vaynberg
>             Fix For: 1.3.5
>
>         Attachments: wicket-1799-wicket-1.3.patch, wicket-1799-wicket-1.4.patch
>
>
> It seems that wicket-extensions (both 1.3 and 1.4) holds an unused reference to common-collections.jar in it's pom.xml. 
>   <dependency>
>     <groupId>commons-collections</groupId>
>     <artifactId>commons-collections</artifactId>
>   </dependency>
> I removed that reference and could still compile everything without any error. Could someone double-check that and remove it if it's really not needed. this would save us from another 570 kb :-)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (WICKET-1799) wicket-extensions has unused reference to commons-collections.jar

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl reopened WICKET-1799:
--------------------------------


for 1.4 the pom.xml is correct, however in 1.3.x the reference is still in there.

> wicket-extensions has unused reference to commons-collections.jar
> -----------------------------------------------------------------
>
>                 Key: WICKET-1799
>                 URL: https://issues.apache.org/jira/browse/WICKET-1799
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>            Reporter: Peter Ertl
>            Assignee: Igor Vaynberg
>             Fix For: 1.3.5
>
>         Attachments: wicket-1799-wicket-1.3.patch, wicket-1799-wicket-1.4.patch
>
>
> It seems that wicket-extensions (both 1.3 and 1.4) holds an unused reference to common-collections.jar in it's pom.xml. 
>   <dependency>
>     <groupId>commons-collections</groupId>
>     <artifactId>commons-collections</artifactId>
>   </dependency>
> I removed that reference and could still compile everything without any error. Could someone double-check that and remove it if it's really not needed. this would save us from another 570 kb :-)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-1799) wicket-extensions has unused reference to commons-collections.jar

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-1799.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.4-M4

> wicket-extensions has unused reference to commons-collections.jar
> -----------------------------------------------------------------
>
>                 Key: WICKET-1799
>                 URL: https://issues.apache.org/jira/browse/WICKET-1799
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>            Reporter: Peter Ertl
>            Assignee: Igor Vaynberg
>             Fix For: 1.3.5, 1.4-M4
>
>         Attachments: wicket-1799-wicket-1.3.patch, wicket-1799-wicket-1.4.patch
>
>
> It seems that wicket-extensions (both 1.3 and 1.4) holds an unused reference to common-collections.jar in it's pom.xml. 
>   <dependency>
>     <groupId>commons-collections</groupId>
>     <artifactId>commons-collections</artifactId>
>   </dependency>
> I removed that reference and could still compile everything without any error. Could someone double-check that and remove it if it's really not needed. this would save us from another 570 kb :-)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1799) wicket-extensions has unused reference to commons-collections.jar

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl updated WICKET-1799:
-------------------------------

    Attachment: wicket-1799-wicket-1.4.patch
                wicket-1799-wicket-1.3.patch

> wicket-extensions has unused reference to commons-collections.jar
> -----------------------------------------------------------------
>
>                 Key: WICKET-1799
>                 URL: https://issues.apache.org/jira/browse/WICKET-1799
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>            Reporter: Peter Ertl
>         Attachments: wicket-1799-wicket-1.3.patch, wicket-1799-wicket-1.4.patch
>
>
> It seems that wicket-extensions (both 1.3 and 1.4) holds an unused reference to common-collections.jar in it's pom.xml. 
>   <dependency>
>     <groupId>commons-collections</groupId>
>     <artifactId>commons-collections</artifactId>
>   </dependency>
> I removed that reference and could still compile everything without any error. Could someone double-check that and remove it if it's really not needed. this would save us from another 570 kb :-)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1799) wicket-extensions has unused reference to commons-collections.jar

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12626921#action_12626921 ] 

Peter Ertl commented on WICKET-1799:
------------------------------------

Patches included...

Got a clean compile on 1.3.x and 1.4.x after removing commons-collections. I see no reason why this reference is needed so please remove it if you agree.

> wicket-extensions has unused reference to commons-collections.jar
> -----------------------------------------------------------------
>
>                 Key: WICKET-1799
>                 URL: https://issues.apache.org/jira/browse/WICKET-1799
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>            Reporter: Peter Ertl
>
> It seems that wicket-extensions (both 1.3 and 1.4) holds an unused reference to common-collections.jar in it's pom.xml. 
>   <dependency>
>     <groupId>commons-collections</groupId>
>     <artifactId>commons-collections</artifactId>
>   </dependency>
> I removed that reference and could still compile everything without any error. Could someone double-check that and remove it if it's really not needed. this would save us from another 570 kb :-)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-1799) wicket-extensions has unused reference to commons-collections.jar

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-1799.
-----------------------------------

       Resolution: Fixed
    Fix Version/s: 1.3.5
         Assignee: Igor Vaynberg

seems like this was already removed from 1.4

> wicket-extensions has unused reference to commons-collections.jar
> -----------------------------------------------------------------
>
>                 Key: WICKET-1799
>                 URL: https://issues.apache.org/jira/browse/WICKET-1799
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>            Reporter: Peter Ertl
>            Assignee: Igor Vaynberg
>             Fix For: 1.3.5
>
>         Attachments: wicket-1799-wicket-1.3.patch, wicket-1799-wicket-1.4.patch
>
>
> It seems that wicket-extensions (both 1.3 and 1.4) holds an unused reference to common-collections.jar in it's pom.xml. 
>   <dependency>
>     <groupId>commons-collections</groupId>
>     <artifactId>commons-collections</artifactId>
>   </dependency>
> I removed that reference and could still compile everything without any error. Could someone double-check that and remove it if it's really not needed. this would save us from another 570 kb :-)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1799) wicket-extensions has unused reference to commons-collections.jar

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl updated WICKET-1799:
-------------------------------

    Attachment:     (was: wicket-1799-wicket-1.4.patch)

> wicket-extensions has unused reference to commons-collections.jar
> -----------------------------------------------------------------
>
>                 Key: WICKET-1799
>                 URL: https://issues.apache.org/jira/browse/WICKET-1799
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>            Reporter: Peter Ertl
>         Attachments: wicket-1799-wicket-1.3.patch, wicket-1799-wicket-1.4.patch
>
>
> It seems that wicket-extensions (both 1.3 and 1.4) holds an unused reference to common-collections.jar in it's pom.xml. 
>   <dependency>
>     <groupId>commons-collections</groupId>
>     <artifactId>commons-collections</artifactId>
>   </dependency>
> I removed that reference and could still compile everything without any error. Could someone double-check that and remove it if it's really not needed. this would save us from another 570 kb :-)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (WICKET-1799) wicket-extensions has unused reference to commons-collections.jar

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl closed WICKET-1799.
------------------------------


thanks!

> wicket-extensions has unused reference to commons-collections.jar
> -----------------------------------------------------------------
>
>                 Key: WICKET-1799
>                 URL: https://issues.apache.org/jira/browse/WICKET-1799
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>            Reporter: Peter Ertl
>            Assignee: Igor Vaynberg
>             Fix For: 1.3.5, 1.4-M4
>
>         Attachments: wicket-1799-wicket-1.3.patch, wicket-1799-wicket-1.4.patch
>
>
> It seems that wicket-extensions (both 1.3 and 1.4) holds an unused reference to common-collections.jar in it's pom.xml. 
>   <dependency>
>     <groupId>commons-collections</groupId>
>     <artifactId>commons-collections</artifactId>
>   </dependency>
> I removed that reference and could still compile everything without any error. Could someone double-check that and remove it if it's really not needed. this would save us from another 570 kb :-)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-1799) wicket-extensions has unused reference to commons-collections.jar

Posted by "Peter Ertl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Peter Ertl updated WICKET-1799:
-------------------------------

    Attachment:     (was: wicket-1799-wicket-1.3.patch)

> wicket-extensions has unused reference to commons-collections.jar
> -----------------------------------------------------------------
>
>                 Key: WICKET-1799
>                 URL: https://issues.apache.org/jira/browse/WICKET-1799
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>            Reporter: Peter Ertl
>         Attachments: wicket-1799-wicket-1.3.patch, wicket-1799-wicket-1.4.patch
>
>
> It seems that wicket-extensions (both 1.3 and 1.4) holds an unused reference to common-collections.jar in it's pom.xml. 
>   <dependency>
>     <groupId>commons-collections</groupId>
>     <artifactId>commons-collections</artifactId>
>   </dependency>
> I removed that reference and could still compile everything without any error. Could someone double-check that and remove it if it's really not needed. this would save us from another 570 kb :-)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.