You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/08/20 06:27:11 UTC
[GitHub] [incubator-kyuubi] zhaomin1423 opened a new pull request, #3286: [KYUUBI #3285] [FEATURE] Add configs to post event async
zhaomin1423 opened a new pull request, #3286:
URL: https://github.com/apache/incubator-kyuubi/pull/3286
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
close https://github.com/apache/incubator-kyuubi/issues/3285#issue-1345037289
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] iodone commented on pull request #3286: [KYUUBI #3285] [FEATURE] Add configs to post event async
Posted by GitBox <gi...@apache.org>.
iodone commented on PR #3286:
URL: https://github.com/apache/incubator-kyuubi/pull/3286#issuecomment-1225638702
@zhaomin1423
The `EventBus` implementation of asynchronous processing triggers a thread for each event and does not implement a consumer-production model with the event message queue, too many `OperationEvent` may lead to excessive thread resource usage. Have you tested the performance of `EventBus` asynchronous handler in a highly concurrent scenario?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3286: [KYUUBI #3285] [FEATURE] Add configs to post event async
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3286:
URL: https://github.com/apache/incubator-kyuubi/pull/3286#issuecomment-1225438849
cc @iodone @wForget
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] github-actions[bot] commented on pull request #3286: [KYUUBI #3285] [FEATURE] Add configs to post event async
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #3286:
URL: https://github.com/apache/incubator-kyuubi/pull/3286#issuecomment-1336285099
Thanks for the PR! This PR is being closed due to inactivity. This isn't a judgement on the merit of the PR in any way. If this is still an issue with the latest version of Kyuubi, please reopen it and ask a committer to remove the Stale tag!
Thank you for using Kyuubi!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zhaomin1423 commented on pull request #3286: [KYUUBI #3285] [FEATURE] Add configs to post event async
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on PR #3286:
URL: https://github.com/apache/incubator-kyuubi/pull/3286#issuecomment-1226841815
> @zhaomin1423 The `EventBus` implementation of asynchronous processing triggers a thread for each event and does not implement a consumer-production model with the event message queue, too many `OperationEvent` may lead to excessive thread resource usage. Have you tested the performance of `EventBus` asynchronous handler in a highly concurrent scenario?
We can add a new async implementation that using consumer-production model later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] github-actions[bot] closed pull request #3286: [KYUUBI #3285] [FEATURE] Add configs to post event async
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #3286: [KYUUBI #3285] [FEATURE] Add configs to post event async
URL: https://github.com/apache/incubator-kyuubi/pull/3286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #3286: [KYUUBI #3285] [FEATURE] Add configs to post event async
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #3286:
URL: https://github.com/apache/kyuubi/pull/3286#issuecomment-1420273089
@zhaomin1423 do you have the opportunity to complete this feature before 1.7? or just postpone to 1.8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org