You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "bbennett-ks (via GitHub)" <gi...@apache.org> on 2026/04/02 17:12:11 UTC
[PR] Guacamole 2255 fix intermittent rdp error handling due to uninitialized variable. [guacamole-server]
bbennett-ks opened a new pull request, #656:
URL: https://github.com/apache/guacamole-server/pull/656
The `connection_closing` variable in `rdp.c` (line 627) is not initialized before use. When RDP event handling fails early in the do-while loop, the code breaks before `connection_closing` is assigned a value, leading to potentially aborting a RDP connection because of an error without report the closing as an error.
This was caused by a fix for GUACAMOLE-2221 (fix RDP busy-loop on transport failure) which added a break.
I cam across this build Guacamole on Rocky 9.
{code:java}
rdp.c: In function 'guac_rdp_client_thread':
rdp.c:658:12: error: 'connection_closing' may be used uninitialized in this function [-Werror=maybe-uninitialized]
658 | if (connection_closing)
| ^
rdp.c:627:13: note: 'connection_closing' was declared here
627 | int connection_closing;
| ^~~~~~~~~~~~~~~~~~
{code}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2255: Fix intermittent rdp error handling due to uninitialized variable. [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman merged PR #656:
URL: https://github.com/apache/guacamole-server/pull/656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GUACAMOLE-2255: Fix intermittent rdp error handling due to uninitialized variable. [guacamole-server]
Posted by "bbennett-ks (via GitHub)" <gi...@apache.org>.
bbennett-ks commented on PR #656:
URL: https://github.com/apache/guacamole-server/pull/656#issuecomment-4179775124
> @bbennett-ks Can you remove the 2254 commit from this? Also, while commit messages are formatted correctly, the title of the PR is not... (Guacamole 2255).
Thanks! Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Guacamole 2255 fix intermittent rdp error handling due to uninitialized variable. [guacamole-server]
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on PR #656:
URL: https://github.com/apache/guacamole-server/pull/656#issuecomment-4179577725
@bbennett-ks Can you remove the 2254 commit from this? Also, while commit messages are formatted correctly, the title of the PR is not... (Guacamole 2255).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org