[GitHub] [incubator-seatunnel] ic4y commented on a diff in pull request #2567: [Feature][ST-Engine] Notice Task State By TaskExecutionService

[GitBox <gi...@apache.org>]

ic4y commented on code in PR #2567:
URL: https://github.com/apache/incubator-seatunnel/pull/2567#discussion_r958448441


##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/PhysicalVertex.java:
##########
@@ -165,12 +166,11 @@ public void deploy(@NonNull Address address) {
 
         try {
             if (ExecutionState.DEPLOYING.equals(executionState.get())) {
-                waitForCompleteByExecutionService = new PassiveCompletableFuture<>(

Review Comment:
   `waitForCompleteByExecutionService` objects are no longer in use



##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelServer.java:
##########
@@ -191,4 +194,16 @@ public JobStatus getJobStatus(long jobId) {
         }
         return runningJobMaster.getJobStatus();
     }
+
+    /**
+     * When TaskGroup ends, it is called by {@link TaskExecutionService} to notify JobMaster the TaskGroup's state.
+     */
+    public void updateTaskExecutionState(TaskExecutionState taskExecutionState) {
+        TaskGroupLocation taskGroupLocation = taskExecutionState.getTaskGroupLocation();
+        JobMaster runningJobMaster = runningJobMasterMap.get(taskGroupLocation.getJobId());
+        if (runningJobMaster == null) {
+            throw new JobException(String.format("Job %s not running", taskGroupLocation.getJobId()));
+        }
+        runningJobMaster.updateTaskExecutionState(taskExecutionState);

Review Comment:
   It is suggest to abstract CoodinationServer to handle JobMaster related operations



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org