You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/25 11:04:28 UTC

[GitHub] [shardingsphere] TeslaCN opened a new issue #13263: Using Collections.synchronizedMap in TableMetaData may impact performance

TeslaCN opened a new issue #13263:
URL: https://github.com/apache/shardingsphere/issues/13263


   ## Refactor
   
   https://github.com/apache/shardingsphere/blob/09b27c273d3a7c7fd31a6853b8e4c95c9b669cb0/shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/metadata/schema/model/TableMetaData.java#L65-L84
   
   I profiled a Proxy which was testing by a 696 terminals benchmarkSQL and found the following result:
   ![image](https://user-images.githubusercontent.com/20503072/138684071-67646cad-c24f-48fc-aae4-eeb6c6ad7ccf.png)
   
   ![image](https://user-images.githubusercontent.com/20503072/138684169-b3617453-917e-448c-8f77-f007fddf6494.png)
   
   The method `org.apache.shardingsphere.proxy.backend.response.header.query.impl.QueryHeaderBuilder#build(org.apache.shardingsphere.infra.executor.sql.execute.result.query.QueryResultMetaData, org.apache.shardingsphere.infra.metadata.ShardingSphereMetaData, int)` is a high frequency invoking method. 
   
   **Consider refactoring the codes used synchronizedMap.**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [shardingsphere] tristaZero closed issue #13263: Using Collections.synchronizedMap in TableMetaData may impact performance

Posted by GitBox <gi...@apache.org>.
tristaZero closed issue #13263:
URL: https://github.com/apache/shardingsphere/issues/13263


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org