You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Girish Shilamkar <gi...@clogeny.com> on 2014/07/22 19:52:21 UTC
Review Request 23819: CLOUDSTACK-2251: Automation tests for dedicated public
IP addreses per tenant feature
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23819/
-----------------------------------------------------------
Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-2251
https://issues.apache.org/jira/browse/CLOUDSTACK-2251
Repository: cloudstack-git
Description
-------
CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per tenant feature
Diffs
-----
test/integration/component/test_dedicate_public_ip_range.py PRE-CREATION
tools/marvin/marvin/config/test_data.py 3cd4b6c
tools/marvin/marvin/lib/base.py 1a32275
Diff: https://reviews.apache.org/r/23819/diff/
Testing
-------
Yes
Thanks,
Girish Shilamkar
Re: Review Request 23819: CLOUDSTACK-2251: Automation tests for
dedicated public IP addreses per tenant feature
Posted by Gaurav Aradhye <ga...@clogeny.com>.
I will check if it applies properly. It is a valid patch in terms of
whether it should be added to repo or not.
Regards,
Gaurav
On Wed, Sep 17, 2014 at 2:42 PM, SrikanteswaraRao Talluri <
srikanteswararao.talluri@citrix.com> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23819/#review53670
> -----------------------------------------------------------
>
>
> Is this patch still valid?
>
> - SrikanteswaraRao Talluri
>
>
> On Sept. 2, 2014, 6:26 a.m., Girish Shilamkar wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/23819/
> > -----------------------------------------------------------
> >
> > (Updated Sept. 2, 2014, 6:26 a.m.)
> >
> >
> > Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
> >
> >
> > Bugs: CLOUDSTACK-2251
> > https://issues.apache.org/jira/browse/CLOUDSTACK-2251
> >
> >
> > Repository: cloudstack-git
> >
> >
> > Description
> > -------
> >
> > CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per
> tenant feature
> >
> >
> > Diffs
> > -----
> >
> > test/integration/component/test_dedicate_public_ip_range.py
> PRE-CREATION
> > tools/marvin/marvin/config/test_data.py ade8657
> > tools/marvin/marvin/lib/base.py 99a541a
> >
> > Diff: https://reviews.apache.org/r/23819/diff/
> >
> >
> > Testing
> > -------
> >
> > Yes
> >
> >
> > Thanks,
> >
> > Girish Shilamkar
> >
> >
>
>
Re: Review Request 23819: CLOUDSTACK-2251: Automation tests for
dedicated public IP addreses per tenant feature
Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23819/#review53670
-----------------------------------------------------------
Is this patch still valid?
- SrikanteswaraRao Talluri
On Sept. 2, 2014, 6:26 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23819/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2014, 6:26 a.m.)
>
>
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-2251
> https://issues.apache.org/jira/browse/CLOUDSTACK-2251
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per tenant feature
>
>
> Diffs
> -----
>
> test/integration/component/test_dedicate_public_ip_range.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py ade8657
> tools/marvin/marvin/lib/base.py 99a541a
>
> Diff: https://reviews.apache.org/r/23819/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 23819: CLOUDSTACK-2251: Automation tests for
dedicated public IP addreses per tenant feature
Posted by Sebastien Goasguen <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23819/#review79029
-----------------------------------------------------------
Thank you for submitting your CloudStack contribution through review board. After discussion on the dev@cloudstack.apache.org the community decided to close down review board and start accepting contributiong through GitHub pull requests. We have been using GH PR for several months now and the process is better than review board.
We will keep Review Board open for another week to give you time to migrate your patch to a github PR if you wish. After that time, your patch will no longer be viewable (even though it will not be deleted).
Please consider submitting a pull request.
Great instructions are available at:
https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md
Thank you very much for your time and your contribution to Apache CloudStack, we hope that using this new process will encourage you to do more.
- Sebastien Goasguen
On Sept. 2, 2014, 6:26 a.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23819/
> -----------------------------------------------------------
>
> (Updated Sept. 2, 2014, 6:26 a.m.)
>
>
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-2251
> https://issues.apache.org/jira/browse/CLOUDSTACK-2251
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per tenant feature
>
>
> Diffs
> -----
>
> test/integration/component/test_dedicate_public_ip_range.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py ade8657
> tools/marvin/marvin/lib/base.py 99a541a
>
> Diff: https://reviews.apache.org/r/23819/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 23819: CLOUDSTACK-2251: Automation tests for
dedicated public IP addreses per tenant feature
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23819/
-----------------------------------------------------------
(Updated Sept. 2, 2014, 6:26 a.m.)
Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-2251
https://issues.apache.org/jira/browse/CLOUDSTACK-2251
Repository: cloudstack-git
Description
-------
CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per tenant feature
Diffs (updated)
-----
test/integration/component/test_dedicate_public_ip_range.py PRE-CREATION
tools/marvin/marvin/config/test_data.py ade8657
tools/marvin/marvin/lib/base.py 99a541a
Diff: https://reviews.apache.org/r/23819/diff/
Testing
-------
Yes
Thanks,
Girish Shilamkar
Re: Review Request 23819: CLOUDSTACK-2251: Automation tests for
dedicated public IP addreses per tenant feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23819/#review51646
-----------------------------------------------------------
Review Changes included in patch at: https://reviews.apache.org/r/25094/
- Ashutosh Kelkar
On July 22, 2014, 5:52 p.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23819/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 5:52 p.m.)
>
>
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-2251
> https://issues.apache.org/jira/browse/CLOUDSTACK-2251
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per tenant feature
>
>
> Diffs
> -----
>
> test/integration/component/test_dedicate_public_ip_range.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py 3cd4b6c
> tools/marvin/marvin/lib/base.py 1a32275
>
> Diff: https://reviews.apache.org/r/23819/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 23819: CLOUDSTACK-2251: Automation tests for
dedicated public IP addreses per tenant feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Aug. 18, 2014, 12:19 p.m., sanjeev n wrote:
> > test/integration/component/test_dedicate_public_ip_range.py, line 920
> > <https://reviews.apache.org/r/23819/diff/1/?file=639413#file639413line920>
> >
> > What is the need for acquiring ip address here? Not deploying any vms in the netowrk so why do we need IP address for source nat?
I will be working on this patch.
Apparently we can't add a guest network without source nat, the network offering does not list out when we try to create a network with network offering which does not provide source nat.
And when the source nat service is enabled for a network, the first public IP acquired is used for source nat and we can't disassociate it.
> On Aug. 18, 2014, 12:19 p.m., sanjeev n wrote:
> > test/integration/component/test_dedicate_public_ip_range.py, line 1080
> > <https://reviews.apache.org/r/23819/diff/1/?file=639413#file639413line1080>
> >
> > Add code to verify the ip range release is success or not.
Will do.
I will add the patch with review changes through my account.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23819/#review50869
-----------------------------------------------------------
On July 22, 2014, 5:52 p.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23819/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 5:52 p.m.)
>
>
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-2251
> https://issues.apache.org/jira/browse/CLOUDSTACK-2251
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per tenant feature
>
>
> Diffs
> -----
>
> test/integration/component/test_dedicate_public_ip_range.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py 3cd4b6c
> tools/marvin/marvin/lib/base.py 1a32275
>
> Diff: https://reviews.apache.org/r/23819/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Girish Shilamkar
>
>
Re: Review Request 23819: CLOUDSTACK-2251: Automation tests for
dedicated public IP addreses per tenant feature
Posted by sanjeev n <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23819/#review50869
-----------------------------------------------------------
test/integration/component/test_dedicate_public_ip_range.py
<https://reviews.apache.org/r/23819/#comment88743>
What is the need for acquiring ip address here? Not deploying any vms in the netowrk so why do we need IP address for source nat?
test/integration/component/test_dedicate_public_ip_range.py
<https://reviews.apache.org/r/23819/#comment88742>
Add code to verify the ip range release is success or not.
- sanjeev n
On July 22, 2014, 5:52 p.m., Girish Shilamkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23819/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 5:52 p.m.)
>
>
> Review request for cloudstack, sanjeev n and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-2251
> https://issues.apache.org/jira/browse/CLOUDSTACK-2251
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-2251: Automation tests for dedicated public IP addreses per tenant feature
>
>
> Diffs
> -----
>
> test/integration/component/test_dedicate_public_ip_range.py PRE-CREATION
> tools/marvin/marvin/config/test_data.py 3cd4b6c
> tools/marvin/marvin/lib/base.py 1a32275
>
> Diff: https://reviews.apache.org/r/23819/diff/
>
>
> Testing
> -------
>
> Yes
>
>
> Thanks,
>
> Girish Shilamkar
>
>