You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by brianshannan-wf <gi...@git.apache.org> on 2016/05/24 21:43:00 UTC
[GitHub] thrift pull request: thrift-3841: dart compact protocol incorrectl...
GitHub user brianshannan-wf opened a pull request:
https://github.com/apache/thrift/pull/1017
thrift-3841: dart compact protocol incorrectly serializes doubles
The compact protocol expects doubles to be serialized/deserialized with a little endian byte order instead of with a network (big endian) byte order. This fixes that. Tested locally by running a go server and dart client with a service containing a method that sent and received a double and making sure what was received on both ends was correct.
@markerickson-wf @tylertreat-wf @stevenosborne-wf
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/brianshannan-wf/thrift thrift-3841
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1017.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1017
----
commit 4d9cb30a0cbb887e126e0c683b2530505193783a
Author: Brian Shannan <br...@workiva.com>
Date: 2016-05-24T18:57:50Z
thrift-3841: dart compact protocol should serialize/deserialize doubles with little endian byte order
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: thrift-3841: dart compact protocol incorrectl...
Posted by brianshannan-wf <gi...@git.apache.org>.
Github user brianshannan-wf closed the pull request at:
https://github.com/apache/thrift/pull/1017
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: thrift-3841: dart compact protocol incorrectl...
Posted by markerickson-wf <gi...@git.apache.org>.
Github user markerickson-wf commented on the pull request:
https://github.com/apache/thrift/pull/1017#issuecomment-221762437
@brianshannan-wf Can you close this PR? I did not construct the commit message correctly for it to be closed automatically.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: thrift-3841: dart compact protocol incorrectl...
Posted by markerickson-wf <gi...@git.apache.org>.
Github user markerickson-wf commented on the pull request:
https://github.com/apache/thrift/pull/1017#issuecomment-221589481
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request: thrift-3841: dart compact protocol incorrectl...
Posted by stevenosborne-wf <gi...@git.apache.org>.
Github user stevenosborne-wf commented on the pull request:
https://github.com/apache/thrift/pull/1017#issuecomment-221568808
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---