You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/13 14:34:26 UTC

[GitHub] [flink] XComp commented on a diff in pull request #19458: [FLINK-27224][build] Drop 'flink.forkCountTestPackage' property

XComp commented on code in PR #19458:
URL: https://github.com/apache/flink/pull/19458#discussion_r849557454


##########
flink-tests/pom.xml:
##########
@@ -404,7 +404,7 @@ under the License.
 					</classpathDependencyExcludes>
 					<!-- We override the fork behaviour for those expensive tests to avoid process
 					kills due to container limits on travis -->
-					<forkCount>${flink.forkCountTestPackage}</forkCount>
+					<forkCount>${flink.forkCount}</forkCount>

Review Comment:
   Can't we get rid of these three lines entirely? We're not overriding anything anymore but do the same thing that's already done in the parent pom...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org