You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Matt McCline (JIRA)" <ji...@apache.org> on 2017/02/14 05:41:41 UTC

[jira] [Comment Edited] (HIVE-15892) Vectorization: Fast Hash tables need to do bounds checking during expand

    [ https://issues.apache.org/jira/browse/HIVE-15892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15865101#comment-15865101 ] 

Matt McCline edited comment on HIVE-15892 at 2/14/17 5:40 AM:
--------------------------------------------------------------

New error message needs work -- it doesn't prescribe a solution.

Add test?

Also add code for BytesBytesMultiHashMap, too?

Files of interest: 
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastHashTable.java
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastBytesHashTable.java
ql/src/java/org/apache/hadoop/hive/ql/exec/vector/mapjoin/fast/VectorMapJoinFastLongHashTable.java


was (Author: mmccline):
New error message needs work -- it doesn't prescribe a solution.

Add test?

Also add code for BytesBytesMultiHashMap, too?

> Vectorization: Fast Hash tables need to do bounds checking during expand
> ------------------------------------------------------------------------
>
>                 Key: HIVE-15892
>                 URL: https://issues.apache.org/jira/browse/HIVE-15892
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive
>            Reporter: Matt McCline
>            Assignee: Matt McCline
>            Priority: Critical
>         Attachments: HIVE-15892.01.patch
>
>
> VectorMapJoinFastLongHashTable line 165 gets NegativeArraySizeException:
> {code}
> long[] newSlotPairs = new long[newSlotPairArraySize];
> {code}
> We need to add a size check... Java math for this wrapped around to negative:
> {code}
> int newSlotPairArraySize = newLogicalHashBucketCount * 2;
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)