[GitHub] [flink] chucheng92 commented on a diff in pull request #21513: [FLINK-30424][streaming] Add source operator addSplits log when restore from state

[GitBox <gi...@apache.org>]

chucheng92 commented on code in PR #21513:
URL: https://github.com/apache/flink/pull/21513#discussion_r1049412147


##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/SourceOperator.java:
##########
@@ -333,6 +333,7 @@ public void open() throws Exception {
         // restore the state if necessary.
         final List<SplitT> splits = CollectionUtil.iterableToList(readerState.get());
         if (!splits.isEmpty()) {
+            LOG.info("Restoring split(s) state to reader {}.", splits);

Review Comment:
   > Because `sourceReader.addSplits(splits)` in the next line will log the details of the splits, maybe we can simply have `LOG.info("Restoring state for {} split(s) to reader.", splits.size())`?
   
   yeah. i think u are right. because next SourceReaderBase will print adding splits details.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org