You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/23 09:04:21 UTC

[GitHub] [skywalking] dmsolr commented on pull request #7153: Support prepare and save metrics concurrency

dmsolr commented on pull request #7153:
URL: https://github.com/apache/skywalking/pull/7153#issuecomment-866663926


   > Hi @a1vin-tian, generally the codes are good. Could you add some comments in the codes for helping readers in the future?
   > It is easier to read currently, but more contributors are going to read this. Such as `prepareDone`, `countDownLatch`, and about many `wait` and `while`.
   
   Yeap. In personally, I am feeling the code is too complex to understand. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org