[GitHub] [superset] rusackas commented on a diff in pull request #20011: fix(chart & heatmap): make to fix that y label is rendering out of bounds

[GitBox <gi...@apache.org>]

rusackas commented on code in PR #20011:
URL: https://github.com/apache/superset/pull/20011#discussion_r869433120


##########
superset-frontend/plugins/legacy-plugin-chart-heatmap/src/Heatmap.js:
##########
@@ -121,6 +121,7 @@ function Heatmap(element, props) {
     let longestY = 1;
 
     records.forEach(datum => {
+      if (typeof datum.y === 'number') pixelsPerCharY = 7;

Review Comment:
   Soon, we may be dealing with different fonts, tool. Is this an issue with the ECharts library itself that we're just working around here? If so, I wonder if they've already addressed it in a newer version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org