[GitHub] [rocketmq-clients] guyinyou commented on issue #294: golang DATA RACE

["guyinyou (via GitHub)" <gi...@apache.org>]

guyinyou commented on issue #294:
URL: https://github.com/apache/rocketmq-clients/issues/294#issuecomment-1487868303

   > I don't think there is a data race there. Above this the global mutex is on so there can be no invocations of the Reset functions concurrently.
   > 
   > ```
   > if !metric.GetOn() {
   > 		dcmp.clientMeter.shutdown()
   > 		sugarBaseLogger.Infof("metric is off, clientId=%s", dcmp.client.GetClientID())
   > 		dcmp.clientMeter = NewDefaultClientMeter(nil, false, nil, dcmp.client.GetClientID()) // DATA RACE
   > 		return
   > 	}
   > ```
   
   You can use the -race parameter to run to know which parts have data race


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org