You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/03/06 11:38:51 UTC
[GitHub] [activemq-artemis] brusdev opened a new pull request #3006:
ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
brusdev opened a new pull request #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] brusdev commented on issue #3006: ARTEMIS-2644
Fix AMQP naming convention in compatibility mode with CORE
Posted by GitBox <gi...@apache.org>.
brusdev commented on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596074607
I could revert all changes and add a prefix to the UUID without a separator, ie
<clientid>-<user>-<ip>-<uuid>. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue
#3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with
CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596058640
E.g.
`ID:<clientid>-USER:<user>-IP:<ip>-<uuid>`
Dropping field if not present (e.g. drop client id part if not set>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] brusdev closed pull request #3006: ARTEMIS-2644
Fix AMQP naming convention in compatibility mode with CORE
Posted by GitBox <gi...@apache.org>.
brusdev closed pull request #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue
#3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with
CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596077583
-1
I think we dont touch the naming, and avoid overloadin If people need to know who created a queue put it on the queue as meta data. That way also multiple fields can be cleanly defined and metricable. This was reason user who created a queue was put on the queue as such if clientid wants to be tracked it can be added in similar fashion as with ip (remote address)
E.g if say wanted to also have the address name in the queue name, so its clear which address it was for when just looking at queue names, the things we could overload into the queue name is endless and get impossible and why overloading the name is a bad idea, let alone the change for existing user.
If people really want to play with queue names its actually possible already today as i had pointed out. They can use shared non durable subscriptions and put what they want as the subscription name giving them ultimate flexibility without affecting anyone else and existing install ba
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #3006:
ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596061074
If a user really really wants the queue name to have a clientid in, they can make a shared non durable subscription with clientid set on connection and then set subscription name to a uuid via jms api
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue
#3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with
CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596058640
E.g.
`ID:<clientid>-USER:<user>-IP:<ip>-<uuid>`
Dropping field if not present (e.g. drop client id)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #3006:
ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596060217
To be honest the more you look at this changing this logic everywhere is lookinh dangerous as breaking some bits possible.
Is the issue that you just need to identify the creator of a queue? Instead of changing the naming strategy why not have meta data on the queue itself, e.g add client id, user and remote address onto the queue meta data?
This also then would work even if clients not upgraded which with core youre relying on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue
#3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with
CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596060217
To be honest the more you look at this changing this logic everywhere is lookingdangerous as breaking some bits possible. Also what occurs when someone wants some other bit of data attached, we change it all again? Meah yucky
Is the issue that you just need to identify the creator of a queue? Instead of changing the naming strategy why not have meta data on the queue itself, e.g add client id, user and remote address onto the queue meta data?
This also then would work even if clients not upgraded which with core youre relying on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue
#3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with
CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596077583
-1
I think we dont touch the naming. If people need to know who created a queue put it on the queue as meta data. That way also multiple fields can be cleanly defined and metricable. This was reason user who created a queue was put on the queue as such if clientid wants to be tracked it can be added in similar fashion as with ip (remote address)
If people really want to play with queue names its actually possible already today as i had pointed out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #3006:
ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596077583
I think we dont touch the naming. If people need to know who created a queue put it on the queue as meta data.
If people really want to play with queue names its actually possible already today as i had pointed out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelpearce-gain edited a comment on issue
#3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with
CORE
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain edited a comment on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-595734781
@brusdev i think we need to address the issue of no client id (e.g. add userid and hostname) before this can merge, dont really want to have two lots of changes in changing the naming strategy;s
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue
#3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with
CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596077583
-1
I think we dont touch the naming. If people need to know who created a queue put it on the queue as meta data. That way also multiple fields can be cleanly defined and metricable. This was reason user who created a queue was put on the queue as such if clientid wants to be tracked it can be added in similar fashion as with ip (remote address)
If people really want to play with queue names its actually possible already today as i had pointed out. They can use shared non durable subscriptions and put what they want as the subscription name giving them ultimate flexibility without affecting anyone else
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue
#3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with
CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596077583
-1
I think we dont touch the naming. If people need to know who created a queue put it on the queue as meta data. That way also multiple fields can be cleanly defined and metricable. This was reason user who created a queue was put on the queue as such if clientid wants to be tracked it can be added in similar fashion as with ip (remote address)
If people really want to play with queue names its actually possible already today as i had pointed out. They can use shared non durable subscriptions and put what they want as the subscription name giving them ultimate flexibility without affecting anyone else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue
#3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with
CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596077583
-1
I think we dont touch the naming. If people need to know who created a queue put it on the queue as meta data. That way also multiple fields can be cleanly defined and metricable.
If people really want to play with queue names its actually possible already today as i had pointed out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #3006:
ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596058640
E.g. ID:<clientid>-IP:<ip>-USER:<user>-<uuid>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue
#3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with
CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596058640
E.g.
`ID:<clientid>.USER:<user>-IP:<ip>.<uuid>`
Dropping field if not present (e.g. drop client id part if not set>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] brusdev edited a comment on issue #3006:
ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
Posted by GitBox <gi...@apache.org>.
brusdev edited a comment on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596074607
I could revert all changes and add a prefix to the UUID without a separator, ie
"< clientid >-< user >-< ip >-< uuid >". WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #3006:
ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596060496
Im going to go ahead and revert whats in master till this is solved, the more i look at this having the extra details at queue level rather than mucking around with changing the existing naming strategy will be less impactful to all
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #3006:
ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596059434
As well should align openwire here also just noticed it has same logic in its naming see AMQConsumer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce commented on issue #3006:
ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce commented on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596057895
I kind of meant use all of it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue
#3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with
CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596061074
If havingg the meta data on the queue doesnt meet a specific users need and a user really really really really really wants the queue name to have a clientid in, they can make a shared non durable subscription with clientid set on connection and then set subscription name to a uuid via jms api. And it would give them the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] brusdev commented on issue #3006: ARTEMIS-2644
Fix AMQP naming convention in compatibility mode with CORE
Posted by GitBox <gi...@apache.org>.
brusdev commented on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596055306
@michaelandrepearce I used user and hostname if no clientid for AMQP queue. Can you check if that's what you meant?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] brusdev edited a comment on issue #3006:
ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
Posted by GitBox <gi...@apache.org>.
brusdev edited a comment on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596074607
I could revert all changes and add a prefix to the UUID without a separator, ie
"<clientid>-<user>-<ip>-<uuid>". WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelpearce-gain commented on issue #3006:
ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-595734781
@brusdev i think we need to address the issue of no client id before this can merge, dont really want to have two lots of changes in changing the naming strategy;s
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue
#3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with
CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596060217
To be honest the more you look at this changing this logic everywhere is lookingdangerous as breaking some bits possible. Also what occurs when someone wants some other bit of data attached, we change it all again? Meah yucky
Is the issue that you just need to identify the creator of a queue? Instead of changing the naming strategy why not have meta data on the queue itself, e.g add client id, user and remote address onto the queue meta data?
We already have user on the queue, just add additional bits into the queue and expose via jmx so available for metrics and console.
This also then would work even if clients not upgraded which with core youre relying on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue
#3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with
CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596058640
E.g.
`ID:<clientid>-IP:<ip>-USER:<user>-<uuid>`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelandrepearce edited a comment on issue
#3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with
CORE
Posted by GitBox <gi...@apache.org>.
michaelandrepearce edited a comment on issue #3006: ARTEMIS-2644 Fix AMQP naming convention in compatibility mode with CORE
URL: https://github.com/apache/activemq-artemis/pull/3006#issuecomment-596077583
-1
I think we dont touch the naming, and avoid overloading them. If people need to know who created a queue put it on the queue as meta data. That way also multiple fields can be cleanly defined and metricable. This was reason user who created a queue was put on the queue as such if clientid wants to be tracked it can be added in similar fashion as with ip (remote address)
If people really want to play with queue names its actually possible already today as i had pointed out. They can use shared non durable subscriptions and put what they want as the subscription name giving them ultimate flexibility without affecting anyone else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services