You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/09/21 12:23:37 UTC
[GitHub] [pinot] navina commented on a diff in pull request #9444: Always pass clientId to kafka's consumer properties
navina commented on code in PR #9444:
URL: https://github.com/apache/pinot/pull/9444#discussion_r976437638
##########
pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaPartitionLevelConnectionHandler.java:
##########
@@ -60,6 +60,7 @@ public KafkaPartitionLevelConnectionHandler(String clientId, StreamConfig stream
if (_config.getKafkaIsolationLevel() != null) {
consumerProp.put(ConsumerConfig.ISOLATION_LEVEL_CONFIG, _config.getKafkaIsolationLevel());
}
+ consumerProp.put(ConsumerConfig.CLIENT_ID_CONFIG, _clientId);
Review Comment:
0.9 consumer seems to be setting this up correctly. No change required. ty!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org