You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joe Smith <ya...@gmail.com> on 2015/02/05 05:13:32 UTC

Review Request 30650: Upgrade virtualenv to 12.0.7

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30650/
-----------------------------------------------------------

Review request for Aurora, Brian Wickman and Zameer Manji.


Bugs: AURORA-979
    https://issues.apache.org/jira/browse/AURORA-979


Repository: aurora


Description
-------

Upgrade virtualenv to 12.0.7

virtualenv
==========

[12.0.7 changelog](https://pypi.python.org/pypi/virtualenv/12.0.7) and selected highlights:

* Upgrade pip to 6.0.8

* Upgrade setuptools to 12.0.5

* Revert several sys.path changes new in 12.0 which were breaking virtualenv.

* **PROCESS** Version numbers are now simply ``X.Y`` where the leading ``1``
has been dropped.
* Now using pytest framework
* Correct sys.path ordering for debian, issue #461
* Correctly throws error on older Pythons, issue #619
* Allow for empty $PATH, pull #601
* Don't set prompt if $env:VIRTUAL_ENV_DISABLE_PROMPT is set for Powershell
* Updated setuptools to 7.0


Diffs
-----

  build-support/virtualenv 0175f0e38e5f995ff4e8335fb86ec14869894e69 

Diff: https://reviews.apache.org/r/30650/diff/


Testing
-------

```sh
$ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all
```


Thanks,

Joe Smith


Re: Review Request 30650: Upgrade virtualenv to 12.0.7

Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30650/#review71171
-----------------------------------------------------------

Ship it!


Ship It!

- Zameer Manji


On Feb. 4, 2015, 8:13 p.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30650/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2015, 8:13 p.m.)
> 
> 
> Review request for Aurora, Brian Wickman and Zameer Manji.
> 
> 
> Bugs: AURORA-979
>     https://issues.apache.org/jira/browse/AURORA-979
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrade virtualenv to 12.0.7
> 
> virtualenv
> ==========
> 
> [12.0.7 changelog](https://pypi.python.org/pypi/virtualenv/12.0.7) and selected highlights:
> 
> * Upgrade pip to 6.0.8
> 
> * Upgrade setuptools to 12.0.5
> 
> * Revert several sys.path changes new in 12.0 which were breaking virtualenv.
> 
> * **PROCESS** Version numbers are now simply ``X.Y`` where the leading ``1``
> has been dropped.
> * Now using pytest framework
> * Correct sys.path ordering for debian, issue #461
> * Correctly throws error on older Pythons, issue #619
> * Allow for empty $PATH, pull #601
> * Don't set prompt if $env:VIRTUAL_ENV_DISABLE_PROMPT is set for Powershell
> * Updated setuptools to 7.0
> 
> 
> Diffs
> -----
> 
>   build-support/virtualenv 0175f0e38e5f995ff4e8335fb86ec14869894e69 
> 
> Diff: https://reviews.apache.org/r/30650/diff/
> 
> 
> Testing
> -------
> 
> ```sh
> $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all
> ```
> 
> 
> Thanks,
> 
> Joe Smith
> 
>


Re: Review Request 30650: Upgrade virtualenv to 12.0.7

Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30650/#review71453
-----------------------------------------------------------

Ship it!


Ship It!

- Brian Wickman


On Feb. 5, 2015, 4:13 a.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30650/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2015, 4:13 a.m.)
> 
> 
> Review request for Aurora, Brian Wickman and Zameer Manji.
> 
> 
> Bugs: AURORA-979
>     https://issues.apache.org/jira/browse/AURORA-979
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrade virtualenv to 12.0.7
> 
> virtualenv
> ==========
> 
> [12.0.7 changelog](https://pypi.python.org/pypi/virtualenv/12.0.7) and selected highlights:
> 
> * Upgrade pip to 6.0.8
> 
> * Upgrade setuptools to 12.0.5
> 
> * Revert several sys.path changes new in 12.0 which were breaking virtualenv.
> 
> * **PROCESS** Version numbers are now simply ``X.Y`` where the leading ``1``
> has been dropped.
> * Now using pytest framework
> * Correct sys.path ordering for debian, issue #461
> * Correctly throws error on older Pythons, issue #619
> * Allow for empty $PATH, pull #601
> * Don't set prompt if $env:VIRTUAL_ENV_DISABLE_PROMPT is set for Powershell
> * Updated setuptools to 7.0
> 
> 
> Diffs
> -----
> 
>   build-support/virtualenv 0175f0e38e5f995ff4e8335fb86ec14869894e69 
> 
> Diff: https://reviews.apache.org/r/30650/diff/
> 
> 
> Testing
> -------
> 
> ```sh
> $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all
> ```
> 
> 
> Thanks,
> 
> Joe Smith
> 
>


Re: Review Request 30650: Upgrade virtualenv to 12.0.7

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30650/#review71157
-----------------------------------------------------------

Ship it!


Master (1c78721) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On Feb. 5, 2015, 4:13 a.m., Joe Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30650/
> -----------------------------------------------------------
> 
> (Updated Feb. 5, 2015, 4:13 a.m.)
> 
> 
> Review request for Aurora, Brian Wickman and Zameer Manji.
> 
> 
> Bugs: AURORA-979
>     https://issues.apache.org/jira/browse/AURORA-979
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Upgrade virtualenv to 12.0.7
> 
> virtualenv
> ==========
> 
> [12.0.7 changelog](https://pypi.python.org/pypi/virtualenv/12.0.7) and selected highlights:
> 
> * Upgrade pip to 6.0.8
> 
> * Upgrade setuptools to 12.0.5
> 
> * Revert several sys.path changes new in 12.0 which were breaking virtualenv.
> 
> * **PROCESS** Version numbers are now simply ``X.Y`` where the leading ``1``
> has been dropped.
> * Now using pytest framework
> * Correct sys.path ordering for debian, issue #461
> * Correctly throws error on older Pythons, issue #619
> * Allow for empty $PATH, pull #601
> * Don't set prompt if $env:VIRTUAL_ENV_DISABLE_PROMPT is set for Powershell
> * Updated setuptools to 7.0
> 
> 
> Diffs
> -----
> 
>   build-support/virtualenv 0175f0e38e5f995ff4e8335fb86ec14869894e69 
> 
> Diff: https://reviews.apache.org/r/30650/diff/
> 
> 
> Testing
> -------
> 
> ```sh
> $ ./pants test.pytest --no-fast ./src/test/python/apache/aurora:all
> ```
> 
> 
> Thanks,
> 
> Joe Smith
> 
>