You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/07/08 13:47:15 UTC
[GitHub] [arrow] nealrichardson opened a new pull request, #13550: ARROW-16268: [R] Remove long-deprecated functions
nealrichardson opened a new pull request, #13550:
URL: https://github.com/apache/arrow/pull/13550
Also has a fix for the check NOTE about union_all and distinct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #13550: ARROW-16268: [R] Remove long-deprecated functions
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on PR #13550:
URL: https://github.com/apache/arrow/pull/13550#issuecomment-1179155666
I looked to the end of the verbose test output, where you see `test-chunked-array` running and then it dies after the assertion on L260: https://github.com/apache/arrow/runs/7243906864?check_suite_focus=true#step:11:6360
So I checked out what's happening in the test. By my reading of the output, it does not always occur, but when it does, it happens when you Filter an empty ChunkedArray with another (boolean) empty ChunkedArray: https://github.com/apache/arrow/blob/master/r/tests/testthat/test-chunked-array.R#L265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #13550: ARROW-16268: [R] Remove long-deprecated functions
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on PR #13550:
URL: https://github.com/apache/arrow/pull/13550#issuecomment-1179092659
Windows CI crash looks like it may be related to https://github.com/apache/arrow/pull/13521 cc @wesm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #13550: ARROW-16268: [R] Remove long-deprecated functions
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #13550:
URL: https://github.com/apache/arrow/pull/13550#issuecomment-1179181868
I have another PR crashing at this line on Windows:
https://github.com/apache/arrow/blob/8116998fe00b0e5d3998577bf442a10b19c66b3d/r/tests/testthat/test-Array.R#L907
(seems also to be subsetting using a boolean)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson merged pull request #13550: ARROW-16268: [R] Remove long-deprecated functions
Posted by GitBox <gi...@apache.org>.
nealrichardson merged PR #13550:
URL: https://github.com/apache/arrow/pull/13550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13550: ARROW-16268: [R] Remove long-deprecated functions
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13550:
URL: https://github.com/apache/arrow/pull/13550#issuecomment-1179009979
https://issues.apache.org/jira/browse/ARROW-16268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #13550: ARROW-16268: [R] Remove long-deprecated functions
Posted by GitBox <gi...@apache.org>.
wesm commented on PR #13550:
URL: https://github.com/apache/arrow/pull/13550#issuecomment-1179158719
Ok I think that gives me enough to go on I’ll try to fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #13550: ARROW-16268: [R] Remove long-deprecated functions
Posted by GitBox <gi...@apache.org>.
wesm commented on PR #13550:
URL: https://github.com/apache/arrow/pull/13550#issuecomment-1179257845
I don't have access to a Windows VM right now otherwise I would try to do it myself, but it should be sufficient to build the C++ library locally with the mingw32 RTools toolchain and run the unit test suite -- building the R package may not be needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #13550: ARROW-16268: [R] Remove long-deprecated functions
Posted by GitBox <gi...@apache.org>.
wesm commented on PR #13550:
URL: https://github.com/apache/arrow/pull/13550#issuecomment-1179820782
Just confirming here also that https://github.com/apache/arrow/commit/88b42ef66fe664043c5ee5274b2982a3858b414e fixed the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wjones127 commented on pull request #13550: ARROW-16268: [R] Remove long-deprecated functions
Posted by GitBox <gi...@apache.org>.
wjones127 commented on PR #13550:
URL: https://github.com/apache/arrow/pull/13550#issuecomment-1179274719
I haven't yet built the 32-bit version, but I will look into that now. My instructions for 64-bit are here FWIW: https://www.datawill.io/2022/04/02/windows-apache-arrow-development-environment-with-rtools-4-0/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #13550: ARROW-16268: [R] Remove long-deprecated functions
Posted by GitBox <gi...@apache.org>.
wesm commented on PR #13550:
URL: https://github.com/apache/arrow/pull/13550#issuecomment-1179119705
Sorry about that -- I see the error in #13521 but I misread the error that it looked like a flake
https://github.com/apache/arrow/runs/7243906864?check_suite_focus=true
What's the best way to diagnose so I can try to fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #13550: ARROW-16268: [R] Remove long-deprecated functions
Posted by GitBox <gi...@apache.org>.
wesm commented on PR #13550:
URL: https://github.com/apache/arrow/pull/13550#issuecomment-1179251552
I've spent about an hour tinkering on this and I feel somewhat powerless to debug the problem. Are there instructions about how to debug the mingw32 RTools 4.0 C++ build on Windows? We don't run the C++ unit tests when building the Arrow libraries, and my guess is that running arrow-compute-vector-test in a debug build will reveal the issue (and with mingw32 we can use gdb to find out where the issue is coming from)? If there's someone better equipped to help identify the issue I would really appreciate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #13550: ARROW-16268: [R] Remove long-deprecated functions
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #13550:
URL: https://github.com/apache/arrow/pull/13550#issuecomment-1179252741
I hate to volunteer @wjones127 for what is probably a hard and possibly time-consuming debugging problem, but I personally consider him the master of debugging R packages on Windows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org