You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by el...@apache.org on 2012/05/11 01:48:13 UTC
svn commit: r1336966 - in
/hadoop/common/trunk/hadoop-common-project/hadoop-common: CHANGES.txt
src/main/java/org/apache/hadoop/fs/BlockLocation.java
src/test/java/org/apache/hadoop/fs/TestBlockLocation.java
Author: eli
Date: Thu May 10 23:48:12 2012
New Revision: 1336966
URL: http://svn.apache.org/viewvc?rev=1336966&view=rev
Log:
HADOOP-8388. Remove unused BlockLocation serialization. Contributed by Colin Patrick McCabe
Removed:
hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestBlockLocation.java
Modified:
hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BlockLocation.java
Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt?rev=1336966&r1=1336965&r2=1336966&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt (original)
+++ hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt Thu May 10 23:48:12 2012
@@ -145,6 +145,9 @@ Release 2.0.0 - UNRELEASED
HADOOP-7920. Remove Avro Rpc. (suresh)
+ HADOOP-8388. Remove unused BlockLocation serialization.
+ (Colin Patrick McCabe via eli)
+
NEW FEATURES
HADOOP-7773. Add support for protocol buffer based RPC engine.
Modified: hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BlockLocation.java
URL: http://svn.apache.org/viewvc/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BlockLocation.java?rev=1336966&r1=1336965&r2=1336966&view=diff
==============================================================================
--- hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BlockLocation.java (original)
+++ hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BlockLocation.java Thu May 10 23:48:12 2012
@@ -35,16 +35,7 @@ import org.apache.hadoop.io.WritableFact
*/
@InterfaceAudience.Public
@InterfaceStability.Stable
-public class BlockLocation implements Writable {
-
- static { // register a ctor
- WritableFactories.setFactory
- (BlockLocation.class,
- new WritableFactory() {
- public Writable newInstance() { return new BlockLocation(); }
- });
- }
-
+public class BlockLocation {
private String[] hosts; //hostnames of datanodes
private String[] names; //hostname:portNumber of datanodes
private String[] topologyPaths; // full path name in network topology
@@ -219,62 +210,6 @@ public class BlockLocation implements Wr
}
}
- /**
- * Implement write of Writable
- */
- public void write(DataOutput out) throws IOException {
- out.writeLong(offset);
- out.writeLong(length);
- out.writeBoolean(corrupt);
- out.writeInt(names.length);
- for (int i=0; i < names.length; i++) {
- Text name = new Text(names[i]);
- name.write(out);
- }
- out.writeInt(hosts.length);
- for (int i=0; i < hosts.length; i++) {
- Text host = new Text(hosts[i]);
- host.write(out);
- }
- out.writeInt(topologyPaths.length);
- for (int i=0; i < topologyPaths.length; i++) {
- Text host = new Text(topologyPaths[i]);
- host.write(out);
- }
- }
-
- /**
- * Implement readFields of Writable
- */
- public void readFields(DataInput in) throws IOException {
- this.offset = in.readLong();
- this.length = in.readLong();
- this.corrupt = in.readBoolean();
- int numNames = in.readInt();
- this.names = new String[numNames];
- for (int i = 0; i < numNames; i++) {
- Text name = new Text();
- name.readFields(in);
- names[i] = name.toString();
- }
-
- int numHosts = in.readInt();
- this.hosts = new String[numHosts];
- for (int i = 0; i < numHosts; i++) {
- Text host = new Text();
- host.readFields(in);
- hosts[i] = host.toString();
- }
-
- int numTops = in.readInt();
- topologyPaths = new String[numTops];
- for (int i = 0; i < numTops; i++) {
- Text path = new Text();
- path.readFields(in);
- topologyPaths[i] = path.toString();
- }
- }
-
public String toString() {
StringBuilder result = new StringBuilder();
result.append(offset);
@@ -289,4 +224,4 @@ public class BlockLocation implements Wr
}
return result.toString();
}
-}
+}
\ No newline at end of file