You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/06 13:09:00 UTC
[jira] [Commented] (THRIFT-3595) Perl Bindings: Set
serialization/deserialization differs
[ https://issues.apache.org/jira/browse/THRIFT-3595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16428282#comment-16428282 ]
ASF GitHub Bot commented on THRIFT-3595:
----------------------------------------
jeking3 commented on issue #831: THRIFT-3595 Perl: Unify implementation of set as a hashref
URL: https://github.com/apache/thrift/pull/831#issuecomment-379247963
Closing based on 2 years on inactivity; superceded by THRIFT-3190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Perl Bindings: Set serialization/deserialization differs
> --------------------------------------------------------
>
> Key: THRIFT-3595
> URL: https://issues.apache.org/jira/browse/THRIFT-3595
> Project: Thrift
> Issue Type: Bug
> Components: Perl - Compiler
> Affects Versions: 0.9.1, 0.9.2, 0.9.3
> Reporter: Adam Millerchip
> Assignee: James E. King, III
> Priority: Major
>
> In the Perl bindings, a Thrift Set is dezerialized as a hashref, but the serialization code expects an arrayref. This causes the code to die when called if attempting to serialize a previously dezerialized Set.
> Additionally, it looks like there is a typo in the test that is testing this feature:
> https://github.com/apache/thrift/blob/49f4dc0cd8c87213a0f80ae1daba2d094a358ea7/test/perl/TestClient.pl#L262
> If you change that {{@$setout}} to {{@$setin}}, the test fails.
> It doesn't make much sense to implement a Set in Perl as array, because arrays allow duplicate entries and are ordered.
> I've written a change for the serialization that correctly expects a hashref: https://github.com/apache/thrift/pull/831
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)