You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@apr.apache.org by be...@apache.org on 2001/02/17 17:10:55 UTC
cvs commit: apr-util Makefile.in
ben 01/02/17 08:10:55
Modified: build buildexports.sh
server Makefile.in
. Makefile.in
. Makefile.in
Log:
Make exports.lo rebuild when it should.
Revision Changes Path
1.11 +2 -1 httpd-2.0/build/buildexports.sh
Index: buildexports.sh
===================================================================
RCS file: /home/cvs/httpd-2.0/build/buildexports.sh,v
retrieving revision 1.10
retrieving revision 1.11
diff -u -r1.10 -r1.11
--- buildexports.sh 2000/12/19 17:05:11 1.10
+++ buildexports.sh 2001/02/17 16:10:54 1.11
@@ -7,7 +7,8 @@
exit 1
fi
-echo "/* This is an ugly hack that needs to be here, so that libtool will"
+echo "/* THIS FILE WAS AUTOGENERATED BY $0"
+echo " * This is an ugly hack that needs to be here, so that libtool will"
echo " * link all of the APR functions into server regardless of whether"
echo " * the base server uses them."
echo " */"
1.33 +3 -0 httpd-2.0/server/Makefile.in
Index: Makefile.in
===================================================================
RCS file: /home/cvs/httpd-2.0/server/Makefile.in,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -r1.32 -r1.33
--- Makefile.in 2001/02/01 21:54:22 1.32
+++ Makefile.in 2001/02/17 16:10:54 1.33
@@ -55,3 +55,6 @@
exports.c: $(EXPORT_FILES)
(cat $(EXPORT_FILES) | ../build/buildexports.sh ..) > $@
+
+# wtf does this have to be explicit????
+exports.lo: exports.c
1.41 +1 -1 apr/Makefile.in
Index: Makefile.in
===================================================================
RCS file: /home/cvs/apr/Makefile.in,v
retrieving revision 1.40
retrieving revision 1.41
diff -u -r1.40 -r1.41
--- Makefile.in 2001/02/16 10:17:10 1.40
+++ Makefile.in 2001/02/17 16:10:55 1.41
@@ -61,7 +61,7 @@
fi \
fi
-$(TARGET_EXPORTS):
+$(TARGET_EXPORTS): include/*.h
$(MKEXPORT) include/*.h > $@
docs:
1.20 +1 -1 apr-util/Makefile.in
Index: Makefile.in
===================================================================
RCS file: /home/cvs/apr-util/Makefile.in,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -r1.19 -r1.20
--- Makefile.in 2001/01/18 23:28:30 1.19
+++ Makefile.in 2001/02/17 16:10:55 1.20
@@ -48,7 +48,7 @@
fi \
fi
-$(TARGET_EXPORTS):
+$(TARGET_EXPORTS): include/*.h
$(AWK) -f @APR_SOURCE_DIR@/helpers/make_export.awk include/*.h > $@ ;
docs:
Re: cvs commit: apr-util Makefile.in
Posted by Ben Laurie <be...@algroup.co.uk>.
Greg Stein wrote:
>
> On Sat, Feb 17, 2001 at 04:10:55PM -0000, ben@apache.org wrote:
> >...
> > --- Makefile.in 2001/02/01 21:54:22 1.32
> > +++ Makefile.in 2001/02/17 16:10:54 1.33
> > @@ -55,3 +55,6 @@
> >
> > exports.c: $(EXPORT_FILES)
> > (cat $(EXPORT_FILES) | ../build/buildexports.sh ..) > $@
> > +
> > +# wtf does this have to be explicit????
> > +exports.lo: exports.c
>
> What OS and make are you using?
3.2-STABLE FreeBSD, using the make that comes with it.
> Did you use the debug flags to 'make' to see
> wtf it was thinking?
No. The amount of output that produces from these makefiles is
ridiculous. I could be persuaded to look but it isn't high on my list!
> I can't imagine it would need to be explicit. Too many other things would
> break. Possibly, it is related to the very dynamic nature of exports.c.
> Possibly, it grabbed all the timestamps at the start of the make, and didn't
> notice the updated timestamp after exports.c was rebuilt.
??? That seems rather unlikely! Make wouldn't work at all in this case.
> Did a second 'make' run fix it? Or did it just persist in being broken? (if
> the former, it might support my hypothesis of grabbing timestamps)
It persisted in being broken.
Cheers,
Ben.
--
http://www.apache-ssl.org/ben.html
"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff
Re: cvs commit: apr-util Makefile.in
Posted by Ben Laurie <be...@algroup.co.uk>.
Greg Stein wrote:
>
> On Sat, Feb 17, 2001 at 04:10:55PM -0000, ben@apache.org wrote:
> >...
> > --- Makefile.in 2001/02/01 21:54:22 1.32
> > +++ Makefile.in 2001/02/17 16:10:54 1.33
> > @@ -55,3 +55,6 @@
> >
> > exports.c: $(EXPORT_FILES)
> > (cat $(EXPORT_FILES) | ../build/buildexports.sh ..) > $@
> > +
> > +# wtf does this have to be explicit????
> > +exports.lo: exports.c
>
> What OS and make are you using? Did you use the debug flags to 'make' to see
> wtf it was thinking?
>
> I can't imagine it would need to be explicit. Too many other things would
> break. Possibly, it is related to the very dynamic nature of exports.c.
> Possibly, it grabbed all the timestamps at the start of the make, and didn't
> notice the updated timestamp after exports.c was rebuilt.
Oh, I should say that the problem was not that it didn't notice the
updated timestamp - the problem was that it didn't rebuild exports.c!
Cheers,
Ben.
--
http://www.apache-ssl.org/ben.html
"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff
Re: cvs commit: apr-util Makefile.in
Posted by Greg Stein <gs...@lyra.org>.
On Sat, Feb 17, 2001 at 04:10:55PM -0000, ben@apache.org wrote:
>...
> --- Makefile.in 2001/02/01 21:54:22 1.32
> +++ Makefile.in 2001/02/17 16:10:54 1.33
> @@ -55,3 +55,6 @@
>
> exports.c: $(EXPORT_FILES)
> (cat $(EXPORT_FILES) | ../build/buildexports.sh ..) > $@
> +
> +# wtf does this have to be explicit????
> +exports.lo: exports.c
What OS and make are you using? Did you use the debug flags to 'make' to see
wtf it was thinking?
I can't imagine it would need to be explicit. Too many other things would
break. Possibly, it is related to the very dynamic nature of exports.c.
Possibly, it grabbed all the timestamps at the start of the make, and didn't
notice the updated timestamp after exports.c was rebuilt.
Did a second 'make' run fix it? Or did it just persist in being broken? (if
the former, it might support my hypothesis of grabbing timestamps)
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
Re: cvs commit: apr-util Makefile.in
Posted by Greg Stein <gs...@lyra.org>.
I've reversed those changes.
On Sat, Feb 17, 2001 at 03:35:18PM -0500, Jeff Trawick wrote:
> ben@apache.org writes:
>
> > Index: Makefile.in
> > ===================================================================
> > RCS file: /home/cvs/apr/Makefile.in,v
> > retrieving revision 1.40
> > retrieving revision 1.41
> > diff -u -r1.40 -r1.41
> > --- Makefile.in 2001/02/16 10:17:10 1.40
> > +++ Makefile.in 2001/02/17 16:10:55 1.41
> > @@ -61,7 +61,7 @@
> > fi \
> > fi
> >
> > -$(TARGET_EXPORTS):
> > +$(TARGET_EXPORTS): include/*.h
>
> Solaris doesn't like this :(
>
> make[3]: *** No rule to make target `include/*.h', needed by `apr.exports'. Stop.
> make[2]: *** [all-recursive] Error 1
> make[1]: *** [all-recursive] Error 1
> make: *** [all-recursive] Error 1
> --------------end of /export/home/trawick/regress/logs/make.stderr-------------
>
> > -$(TARGET_EXPORTS):
> > +$(TARGET_EXPORTS): include/*.h
> > $(AWK) -f @APR_SOURCE_DIR@/helpers/make_export.awk include/*.h > $@ ;
>
> again
>
> --
> Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
> http://www.geocities.com/SiliconValley/Park/9289/
> Born in Roswell... married an alien...
--
Greg Stein, http://www.lyra.org/
Re: cvs commit: apr-util Makefile.in
Posted by Jeff Trawick <tr...@bellsouth.net>.
ben@apache.org writes:
> Index: Makefile.in
> ===================================================================
> RCS file: /home/cvs/apr/Makefile.in,v
> retrieving revision 1.40
> retrieving revision 1.41
> diff -u -r1.40 -r1.41
> --- Makefile.in 2001/02/16 10:17:10 1.40
> +++ Makefile.in 2001/02/17 16:10:55 1.41
> @@ -61,7 +61,7 @@
> fi \
> fi
>
> -$(TARGET_EXPORTS):
> +$(TARGET_EXPORTS): include/*.h
Solaris doesn't like this :(
make[3]: *** No rule to make target `include/*.h', needed by `apr.exports'. Stop.
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all-recursive] Error 1
--------------end of /export/home/trawick/regress/logs/make.stderr-------------
> -$(TARGET_EXPORTS):
> +$(TARGET_EXPORTS): include/*.h
> $(AWK) -f @APR_SOURCE_DIR@/helpers/make_export.awk include/*.h > $@ ;
again
--
Jeff Trawick | trawickj@bellsouth.net | PGP public key at web site:
http://www.geocities.com/SiliconValley/Park/9289/
Born in Roswell... married an alien...