You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by "June Ng (JIRA)" <xa...@xml.apache.org> on 2005/03/24 23:21:24 UTC

[jira] Created: (XALANC-470) runConfigure does not pass link options to Makefile for AIX platform

runConfigure does not pass link options to Makefile for AIX platform
--------------------------------------------------------------------

         Key: XALANC-470
         URL: http://issues.apache.org/jira/browse/XALANC-470
     Project: XalanC
        Type: Bug
  Components: XalanC  
    Versions: CurrentCVS    
 Environment: AIX
    Reporter: June Ng


Discovered this a while back when doing a build on AIX.  runConfigure allows the user to specify additional link options via the 'l' flag, but it seems that on AIX, the user provided options are not appended to LDFLAGS.

When link options are passed to runConfigure via the -l flag, they get stored in $linkeroptions .. which gets passed to 

LDFLAGS="$LDFLAGS $linkeroptions $bitstobuildLink"
export LDFLAGS

But in Makefile.incl.in file, very few platforms include the $LDFLAGS in their link step.  For example, on the AIX platform:

MAKE_SHARED = makeC++SharedLib_r -p 512 -brtl ${bitstobuildLink}
LINK = $(CXX) -qnotempinc $(CXXFLAGS)  -brtl $(PLATFORM_COMPILE_OPTIONS) ${bitstobuildLink}

No mention of LDFLAGS in the link step.  There are only a few platforms that use LDFLAGS at the link step but the majority of the platforms don't.

This should be cleaned up.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Resolved: (XALANC-470) runConfigure does not pass link options to Makefile for AIX platform

Posted by "June Ng (JIRA)" <xa...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XALANC-470?page=all ]
     
June Ng resolved XALANC-470:
----------------------------

    Resolution: Fixed

Patch applied.

> runConfigure does not pass link options to Makefile for AIX platform
> --------------------------------------------------------------------
>
>          Key: XALANC-470
>          URL: http://issues.apache.org/jira/browse/XALANC-470
>      Project: XalanC
>         Type: Bug
>   Components: XalanC
>     Versions: CurrentCVS
>  Environment: AIX
>     Reporter: June Ng
>     Assignee: June Ng
>  Attachments: PatchXalanC470.txt
>
> Discovered this a while back when doing a build on AIX.  runConfigure allows the user to specify additional link options via the 'l' flag, but it seems that on AIX, the user provided options are not appended to LDFLAGS.
> When link options are passed to runConfigure via the -l flag, they get stored in $linkeroptions .. which gets passed to 
> LDFLAGS="$LDFLAGS $linkeroptions $bitstobuildLink"
> export LDFLAGS
> But in Makefile.incl.in file, very few platforms include the $LDFLAGS in their link step.  For example, on the AIX platform:
> MAKE_SHARED = makeC++SharedLib_r -p 512 -brtl ${bitstobuildLink}
> LINK = $(CXX) -qnotempinc $(CXXFLAGS)  -brtl $(PLATFORM_COMPILE_OPTIONS) ${bitstobuildLink}
> No mention of LDFLAGS in the link step.  There are only a few platforms that use LDFLAGS at the link step but the majority of the platforms don't.
> This should be cleaned up.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Commented: (XALANC-470) runConfigure does not pass link options to Makefile for AIX platform

Posted by "Matt Hoyt (JIRA)" <xa...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XALANC-470?page=comments#action_64649 ]
     
Matt Hoyt commented on XALANC-470:
----------------------------------

Looks fine.   

I  would also suggest removing redundant EXTRA_LINK_OPTIONS=$(LDFLAGS) lines from the Makefile.incl.in.

> runConfigure does not pass link options to Makefile for AIX platform
> --------------------------------------------------------------------
>
>          Key: XALANC-470
>          URL: http://issues.apache.org/jira/browse/XALANC-470
>      Project: XalanC
>         Type: Bug
>   Components: XalanC
>     Versions: CurrentCVS
>  Environment: AIX
>     Reporter: June Ng
>     Assignee: June Ng
>  Attachments: PatchXalanC470.txt
>
> Discovered this a while back when doing a build on AIX.  runConfigure allows the user to specify additional link options via the 'l' flag, but it seems that on AIX, the user provided options are not appended to LDFLAGS.
> When link options are passed to runConfigure via the -l flag, they get stored in $linkeroptions .. which gets passed to 
> LDFLAGS="$LDFLAGS $linkeroptions $bitstobuildLink"
> export LDFLAGS
> But in Makefile.incl.in file, very few platforms include the $LDFLAGS in their link step.  For example, on the AIX platform:
> MAKE_SHARED = makeC++SharedLib_r -p 512 -brtl ${bitstobuildLink}
> LINK = $(CXX) -qnotempinc $(CXXFLAGS)  -brtl $(PLATFORM_COMPILE_OPTIONS) ${bitstobuildLink}
> No mention of LDFLAGS in the link step.  There are only a few platforms that use LDFLAGS at the link step but the majority of the platforms don't.
> This should be cleaned up.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Updated: (XALANC-470) runConfigure does not pass link options to Makefile for AIX platform

Posted by "June Ng (JIRA)" <xa...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XALANC-470?page=all ]

June Ng updated XALANC-470:
---------------------------

    Attachment: PatchXalanC470.txt

Patch appends the ${LDFLAGS} env var to all link steps that are missing this.  The purpose of this is to ensure that addition link options specified during runConfigure, are passed down and actually used.

Committers, please review this patch?  It affects *all* platforms so review with caution.

> runConfigure does not pass link options to Makefile for AIX platform
> --------------------------------------------------------------------
>
>          Key: XALANC-470
>          URL: http://issues.apache.org/jira/browse/XALANC-470
>      Project: XalanC
>         Type: Bug
>   Components: XalanC
>     Versions: CurrentCVS
>  Environment: AIX
>     Reporter: June Ng
>     Assignee: June Ng
>  Attachments: PatchXalanC470.txt
>
> Discovered this a while back when doing a build on AIX.  runConfigure allows the user to specify additional link options via the 'l' flag, but it seems that on AIX, the user provided options are not appended to LDFLAGS.
> When link options are passed to runConfigure via the -l flag, they get stored in $linkeroptions .. which gets passed to 
> LDFLAGS="$LDFLAGS $linkeroptions $bitstobuildLink"
> export LDFLAGS
> But in Makefile.incl.in file, very few platforms include the $LDFLAGS in their link step.  For example, on the AIX platform:
> MAKE_SHARED = makeC++SharedLib_r -p 512 -brtl ${bitstobuildLink}
> LINK = $(CXX) -qnotempinc $(CXXFLAGS)  -brtl $(PLATFORM_COMPILE_OPTIONS) ${bitstobuildLink}
> No mention of LDFLAGS in the link step.  There are only a few platforms that use LDFLAGS at the link step but the majority of the platforms don't.
> This should be cleaned up.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Closed: (XALANC-470) runConfigure does not pass link options to Makefile for AIX platform

Posted by "June Ng (JIRA)" <xa...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XALANC-470?page=all ]
     
June Ng closed XALANC-470:
--------------------------


> runConfigure does not pass link options to Makefile for AIX platform
> --------------------------------------------------------------------
>
>          Key: XALANC-470
>          URL: http://issues.apache.org/jira/browse/XALANC-470
>      Project: XalanC
>         Type: Bug
>   Components: XalanC
>     Versions: CurrentCVS
>  Environment: AIX
>     Reporter: June Ng
>     Assignee: June Ng
>  Attachments: PatchXalanC470.txt
>
> Discovered this a while back when doing a build on AIX.  runConfigure allows the user to specify additional link options via the 'l' flag, but it seems that on AIX, the user provided options are not appended to LDFLAGS.
> When link options are passed to runConfigure via the -l flag, they get stored in $linkeroptions .. which gets passed to 
> LDFLAGS="$LDFLAGS $linkeroptions $bitstobuildLink"
> export LDFLAGS
> But in Makefile.incl.in file, very few platforms include the $LDFLAGS in their link step.  For example, on the AIX platform:
> MAKE_SHARED = makeC++SharedLib_r -p 512 -brtl ${bitstobuildLink}
> LINK = $(CXX) -qnotempinc $(CXXFLAGS)  -brtl $(PLATFORM_COMPILE_OPTIONS) ${bitstobuildLink}
> No mention of LDFLAGS in the link step.  There are only a few platforms that use LDFLAGS at the link step but the majority of the platforms don't.
> This should be cleaned up.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org


[jira] Assigned: (XALANC-470) runConfigure does not pass link options to Makefile for AIX platform

Posted by "June Ng (JIRA)" <xa...@xml.apache.org>.
     [ http://issues.apache.org/jira/browse/XALANC-470?page=all ]

June Ng reassigned XALANC-470:
------------------------------

    Assign To: June Ng

> runConfigure does not pass link options to Makefile for AIX platform
> --------------------------------------------------------------------
>
>          Key: XALANC-470
>          URL: http://issues.apache.org/jira/browse/XALANC-470
>      Project: XalanC
>         Type: Bug
>   Components: XalanC
>     Versions: CurrentCVS
>  Environment: AIX
>     Reporter: June Ng
>     Assignee: June Ng

>
> Discovered this a while back when doing a build on AIX.  runConfigure allows the user to specify additional link options via the 'l' flag, but it seems that on AIX, the user provided options are not appended to LDFLAGS.
> When link options are passed to runConfigure via the -l flag, they get stored in $linkeroptions .. which gets passed to 
> LDFLAGS="$LDFLAGS $linkeroptions $bitstobuildLink"
> export LDFLAGS
> But in Makefile.incl.in file, very few platforms include the $LDFLAGS in their link step.  For example, on the AIX platform:
> MAKE_SHARED = makeC++SharedLib_r -p 512 -brtl ${bitstobuildLink}
> LINK = $(CXX) -qnotempinc $(CXXFLAGS)  -brtl $(PLATFORM_COMPILE_OPTIONS) ${bitstobuildLink}
> No mention of LDFLAGS in the link step.  There are only a few platforms that use LDFLAGS at the link step but the majority of the platforms don't.
> This should be cleaned up.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org