[GitHub] [beam] ibzib commented on a change in pull request #13691: Add version and sdk_version as inputs to ProcessResources task.

[GitBox <gi...@apache.org>]

ibzib commented on a change in pull request #13691:
URL: https://github.com/apache/beam/pull/13691#discussion_r553541868



##########
File path: sdks/java/core/build.gradle
##########
@@ -49,11 +49,11 @@ interface for processing virtually any size data. This
 artifact includes entire Apache Beam Java SDK."""
 
 processResources {
+  inputs.property('version', version)

Review comment:
       I didn't realize we could use properties as inputs. Thanks for showing me the right way to do this :)

##########
File path: sdks/java/core/build.gradle
##########
@@ -49,11 +49,11 @@ interface for processing virtually any size data. This
 artifact includes entire Apache Beam Java SDK."""
 
 processResources {
+  inputs.property('version', version)
+  inputs.property('sdk_version', sdk_version)
   filter org.apache.tools.ant.filters.ReplaceTokens, tokens: [
     'pom.version': version,
     'pom.sdk_version': sdk_version,
-    'pom.docker_image_default_repo_root': docker_image_default_repo_root,

Review comment:
       We still use these here: https://github.com/apache/beam/blob/0c01636fc8610414859d946cb93eabc904123fc8/sdks/java/core/src/main/java/org/apache/beam/sdk/util/ReleaseInfo.java#L107
   
   Can we make `docker_image_default_repo_root` and `docker_image_default_repo_prefix` inputs as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org