You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Bernd Mathiske (JIRA)" <ji...@apache.org> on 2014/11/04 11:50:33 UTC

[jira] [Created] (MESOS-2038) Remove dead code in Slave::_runTask

Bernd Mathiske created MESOS-2038:
-------------------------------------

             Summary: Remove dead code in Slave::_runTask
                 Key: MESOS-2038
                 URL: https://issues.apache.org/jira/browse/MESOS-2038
             Project: Mesos
          Issue Type: Improvement
          Components: slave
    Affects Versions: 0.21.0
            Reporter: Bernd Mathiske
            Assignee: Bernd Mathiske
            Priority: Trivial
             Fix For: 0.22.0


In the course of fixing MESOS-947, it has been overlooked by me that the code in question became dead code. Coverty caught this. 

At the top of _runTask(), there is now a test whether framework is NULL and in each case it ever is before reaching the code in question (see below) there is a local exit from the method. So we should be able to remove this code without effect:

-  if (framework == NULL) {
-    framework = new Framework(this, frameworkId, frameworkInfo, pid);
-    frameworks[frameworkId] = framework;
-  }
-
-  CHECK_NOTNULL(framework);
-




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)