[GitHub] [ignite-3] sergeyuttsel commented on a diff in pull request #1477: IGNITE-18141 Added ability to bind tables with distribution zones on table creation.

[GitBox <gi...@apache.org>]

sergeyuttsel commented on code in PR #1477:
URL: https://github.com/apache/ignite-3/pull/1477#discussion_r1065408386


##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/DistributionZoneManager.java:
##########
@@ -328,20 +341,34 @@ public CompletableFuture<Void> dropZone(String name) {
             CompletableFuture<Void> fut = new CompletableFuture<>();
 
             zonesConfiguration.change(zonesChange -> zonesChange.changeDistributionZones(zonesListChange -> {
-                DistributionZoneView view = zonesListChange.get(name);
+                DistributionZoneView zoneView = zonesListChange.get(name);
 
-                if (view == null) {
+                if (zoneView == null) {
                     throw new DistributionZoneNotFoundException(name);
                 }
 
+                NamedConfigurationTree<TableConfiguration, TableView, TableChange> tables = tablesConfiguration.tables();
+
+                boolean bindTable = tables.value().namedListKeys().stream()

Review Comment:
   The idea was that this is not possible, since we do this in the "change". But it turned out that it doesn't work that way. I'll create a ticket for this issue, but for now let's leave it like that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org