You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Marshall (Code Review)" <ge...@cloudera.org> on 2019/04/03 23:39:23 UTC
[native-toolchain-CR] Remove '-static-libstdc++' from CXXFLAGS
Thomas Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12929
Change subject: Remove '-static-libstdc++' from CXXFLAGS
......................................................................
Remove '-static-libstdc++' from CXXFLAGS
CXXFLAGS used to be ignored by the Kudu build but a change upstream,
which was pulled in when the toolchain Kudu version was bumped to
1.9.0, makes it take effect, which caused problems - impalads crash
immediately upon startup when linked against a libkudu_client.so built
with these CXXFLAGS.
This patch removes the flag '-static-libstdc++' so that we link
to libstdc++.so we ship rather than having two versions of the symbols
in two libraries.
Change-Id: Icb95520f98ee9ff46c4a64e3aec1c26eee144f5b
---
M init-compiler.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/29/12929/1
--
To view, visit http://gerrit.cloudera.org:8080/12929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb95520f98ee9ff46c4a64e3aec1c26eee144f5b
Gerrit-Change-Number: 12929
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
[native-toolchain-CR] Remove '-static-libstdc++' from CXXFLAGS
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12929 )
Change subject: Remove '-static-libstdc++' from CXXFLAGS
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb95520f98ee9ff46c4a64e3aec1c26eee144f5b
Gerrit-Change-Number: 12929
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Apr 2019 23:48:55 +0000
Gerrit-HasComments: No
[native-toolchain-CR] Remove '-static-libstdc++' from CXXFLAGS
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12929 )
Change subject: Remove '-static-libstdc++' from CXXFLAGS
......................................................................
Remove '-static-libstdc++' from CXXFLAGS
CXXFLAGS used to be ignored by the Kudu build but a change upstream,
which was pulled in when the toolchain Kudu version was bumped to
1.9.0, makes it take effect, which caused problems - impalads crash
immediately upon startup when linked against a libkudu_client.so built
with these CXXFLAGS.
This patch removes the flag '-static-libstdc++' so that we link
to libstdc++.so we ship rather than having two versions of the symbols
in two libraries.
Change-Id: Icb95520f98ee9ff46c4a64e3aec1c26eee144f5b
Reviewed-on: http://gerrit.cloudera.org:8080/12929
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Thomas Marshall <tm...@cloudera.com>
---
M init-compiler.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Lars Volker: Looks good to me, approved
Thomas Marshall: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb95520f98ee9ff46c4a64e3aec1c26eee144f5b
Gerrit-Change-Number: 12929
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[native-toolchain-CR] Remove '-static-libstdc++' from CXXFLAGS
Posted by "Thomas Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/12929 )
Change subject: Remove '-static-libstdc++' from CXXFLAGS
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12929
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb95520f98ee9ff46c4a64e3aec1c26eee144f5b
Gerrit-Change-Number: 12929
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Hector Acosta <he...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Thomas Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Apr 2019 00:04:06 +0000
Gerrit-HasComments: No