[jira] [Commented] (HBASE-11318) Classes in security subpackages missing @InterfaceAudience annotations.

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-11318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14026817#comment-14026817 ] 

Hadoop QA commented on HBASE-11318:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12649613/hbase-11318.patch
  against trunk revision .
  ATTACHMENT ID: 12649613

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 1 warning messages.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/9734//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9734//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9734//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9734//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9734//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9734//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9734//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9734//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9734//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/9734//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/9734//console

This message is automatically generated.

> Classes in security subpackages missing @InterfaceAudience annotations.
> -----------------------------------------------------------------------
>
>                 Key: HBASE-11318
>                 URL: https://issues.apache.org/jira/browse/HBASE-11318
>             Project: HBase
>          Issue Type: Bug
>          Components: security
>    Affects Versions: 0.99.0, 0.96.1.1, 0.98.3
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 0.99.0, 0.98.4
>
>         Attachments: hbase-11318.patch
>
>
> I was reading some of the security related code and noticed that many of the security related classes lack @InterfaceAudience markings.
> WIth the current api I believe all but Permission should be Private.  With the introduction of cell level ACL's Permission must be public because it is now exposed in the Mutation setACL calls[1].  
> There is an inconsistency with the Mutation ACL -- the acl setters take Permission instances but the getter returns byte[]'s.  As a follow on issue we could change the signature of Mutation.setACL so we don't have to expose the Permission class and convert it to be byte[], or change the getter to return an exposed Permission instance.
> [1] http://hbase.apache.org/devapidocs/org/apache/hadoop/hbase/client/Mutation.html#setACL(java.util.Map)



--
This message was sent by Atlassian JIRA
(v6.2#6252)