[Bug 5753] New: Make the log_scan_result plugin call more useful

[bu...@bugzilla.spamassassin.org]

http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5753

           Summary: Make the log_scan_result plugin call more useful
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Plugins
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: felicity@apache.org


A mail on the users list was asking about logging results to a database.  I was
going to say "use log_scan_result", except then I looked at the call in spamd:

  $spamtest->call_plugins("log_scan_result", { result => $log });

and $log is:

  my $log = sprintf("spamd: result: %s %2d - %s %s", $yorn, $score,
               $tests, join(",", @extra));

Which is great if all you care about is the score and the list of rules that
hit, and you feel like parsing the data back out from a scalar ...

I'd like to see several things happen:

a) Send the variables separately.  ie: $yorn, $score, $tests, @extra.
b) Include the actual message.  ie: $mail
c) Perhaps send $status, like most other calls, as well or instead, and let the
plugin figure out what to do via PMS.
d) Send some spamd information, like check() time, $current_user, client IP, etc.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 5753] Make the log_scan_result plugin call more useful

[bu...@bugzilla.spamassassin.org]

http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5753





------- Additional Comments From jm@jmason.org  2007-12-20 08:53 -------
feel free to add an additional call_plugins() hook; but log_scan_result uses
a well-defined format, even if it *is* a scalar ;)  see the POD:

    The 'result: ...' line for this scan.  Format is as described at
    http://wiki.apache.org/spamassassin/SpamdSyslogFormat.

there's plenty of additional comma-separated name=value metadata in that
line, btw.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 5753] Make the log_scan_result plugin call more useful

[bu...@bugzilla.spamassassin.org]

http://issues.apache.org/SpamAssassin/show_bug.cgi?id=5753





------- Additional Comments From parkerm@pobox.com  2007-12-20 08:51 -------
OH yes! +1 from me, the current call is far too basic.



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.