You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Charles Reiss <wo...@gmail.com> on 2012/07/13 01:49:42 UTC
Review Request: Explicitly default-construct flags member of Master
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5924/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Description
-------
An explicit initializer-list call to the default-constructor for the flags member of Master cannot be omitted because it is const and the default-constructor is not user-defined. (My draft copy of the C++ standard specifies "If a program calls for the default initialization of an object of a const-qualified type T, T shall be a class type with a user-provided default constructor." in [dcl.init].) GCC 4.6 complains about this.
Diffs
-----
src/master/master.cpp 4cfd679
Diff: https://reviews.apache.org/r/5924/diff/
Testing
-------
Thanks,
Charles Reiss
Re: Review Request: Explicitly default-construct flags member of Master
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5924/#review9311
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On July 12, 2012, 11:49 p.m., Charles Reiss wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5924/
> -----------------------------------------------------------
>
> (Updated July 12, 2012, 11:49 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> An explicit initializer-list call to the default-constructor for the flags member of Master cannot be omitted because it is const and the default-constructor is not user-defined. (My draft copy of the C++ standard specifies "If a program calls for the default initialization of an object of a const-qualified type T, T shall be a class type with a user-provided default constructor." in [dcl.init].) GCC 4.6 complains about this.
>
>
> Diffs
> -----
>
> src/master/master.cpp 4cfd679
>
> Diff: https://reviews.apache.org/r/5924/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Charles Reiss
>
>