You are viewing a plain text version of this content. The canonical link for it is here.
Posted to proton@qpid.apache.org by "Rob Godfrey (JIRA)" <ji...@apache.org> on 2012/10/15 14:12:02 UTC

[jira] [Created] (PROTON-76) Suspiciously insufficient looking buffer allocation in messenger.c

Rob Godfrey created PROTON-76:
---------------------------------

             Summary: Suspiciously insufficient looking buffer allocation in messenger.c
                 Key: PROTON-76
                 URL: https://issues.apache.org/jira/browse/PROTON-76
             Project: Qpid Proton
          Issue Type: Bug
          Components: proton-c
            Reporter: Rob Godfrey


Lines 541-549:


  if (len > 1 && address[0] == '~' && address[1] == '/') {
    char buf[len + strlen(mng->name) + 4];
    sprintf(buf, "amqp://%s/%s", mng->name, address);
    pn_message_set_reply_to(msg, buf);
  } else if (len == 0) {
    char buf[strlen(mng->name) + 4];
    sprintf(buf, "amqp://%s", mng->name);
    pn_message_set_reply_to(msg, buf);
  }

should the first "4" not be an "8" and the second a "7"?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PROTON-76) Suspiciously insufficient looking buffer allocation in messenger.c

Posted by "Rafael H. Schloming (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PROTON-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rafael H. Schloming updated PROTON-76:
--------------------------------------

    Assignee: Rafael H. Schloming
    
> Suspiciously insufficient looking buffer allocation in messenger.c
> ------------------------------------------------------------------
>
>                 Key: PROTON-76
>                 URL: https://issues.apache.org/jira/browse/PROTON-76
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>            Reporter: Rob Godfrey
>            Assignee: Rafael H. Schloming
>            Priority: Blocker
>
> Lines 541-549:
>   if (len > 1 && address[0] == '~' && address[1] == '/') {
>     char buf[len + strlen(mng->name) + 4];
>     sprintf(buf, "amqp://%s/%s", mng->name, address);
>     pn_message_set_reply_to(msg, buf);
>   } else if (len == 0) {
>     char buf[strlen(mng->name) + 4];
>     sprintf(buf, "amqp://%s", mng->name);
>     pn_message_set_reply_to(msg, buf);
>   }
> should the first "4" not be an "8" and the second a "7"?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (PROTON-76) Suspiciously insufficient looking buffer allocation in messenger.c

Posted by "Rafael H. Schloming (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PROTON-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rafael H. Schloming resolved PROTON-76.
---------------------------------------

    Resolution: Fixed
    
> Suspiciously insufficient looking buffer allocation in messenger.c
> ------------------------------------------------------------------
>
>                 Key: PROTON-76
>                 URL: https://issues.apache.org/jira/browse/PROTON-76
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>            Reporter: Rob Godfrey
>            Assignee: Rafael H. Schloming
>            Priority: Blocker
>
> Lines 541-549:
>   if (len > 1 && address[0] == '~' && address[1] == '/') {
>     char buf[len + strlen(mng->name) + 4];
>     sprintf(buf, "amqp://%s/%s", mng->name, address);
>     pn_message_set_reply_to(msg, buf);
>   } else if (len == 0) {
>     char buf[strlen(mng->name) + 4];
>     sprintf(buf, "amqp://%s", mng->name);
>     pn_message_set_reply_to(msg, buf);
>   }
> should the first "4" not be an "8" and the second a "7"?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (PROTON-76) Suspiciously insufficient looking buffer allocation in messenger.c

Posted by "Rafael H. Schloming (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/PROTON-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rafael H. Schloming updated PROTON-76:
--------------------------------------

    Priority: Blocker  (was: Major)
    
> Suspiciously insufficient looking buffer allocation in messenger.c
> ------------------------------------------------------------------
>
>                 Key: PROTON-76
>                 URL: https://issues.apache.org/jira/browse/PROTON-76
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: proton-c
>            Reporter: Rob Godfrey
>            Priority: Blocker
>
> Lines 541-549:
>   if (len > 1 && address[0] == '~' && address[1] == '/') {
>     char buf[len + strlen(mng->name) + 4];
>     sprintf(buf, "amqp://%s/%s", mng->name, address);
>     pn_message_set_reply_to(msg, buf);
>   } else if (len == 0) {
>     char buf[strlen(mng->name) + 4];
>     sprintf(buf, "amqp://%s", mng->name);
>     pn_message_set_reply_to(msg, buf);
>   }
> should the first "4" not be an "8" and the second a "7"?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira