[GitHub] [kafka] hgeraldino commented on a diff in pull request #13193: KAFKA-14659 source-record-write-[rate|total] metrics include filtered records

["hgeraldino (via GitHub)" <gi...@apache.org>]

hgeraldino commented on code in PR #13193:
URL: https://github.com/apache/kafka/pull/13193#discussion_r1119214853


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetricsRegistry.java:
##########
@@ -187,7 +187,8 @@ public ConnectMetricsRegistry(Set<String> tags) {
         sourceRecordWriteTotal = createTemplate("source-record-write-total", SOURCE_TASK_GROUP_NAME,
                                                 "The number of records output from the transformations and written to Kafka for this" +
                                                 " task belonging to the named source connector in this worker, since the task was " +
-                                                "last restarted.",
+                                                "last restarted. This is after transformations are applied and excludes any records " +
+                                                "filtered out by the transformations.",

Review Comment:
   Fair question. The `source-record-write-rate` template declared just above  (L181) includes this text, so I thought about adding it here as well to maintain uniformity between the two.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org