[jira] [Commented] (ISIS-837) In Wicket viewer, forms not flushing properties when annotated with JDO @NotPersistent.

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ISIS-837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14061119#comment-14061119 ] 

ASF subversion and git services commented on ISIS-837:
------------------------------------------------------

Commit 877e7eddfa49cad5869d8cf97982c75d9e84196f in isis's branch refs/heads/master from [~danhaywood]
[ https://git-wip-us.apache.org/repos/asf?p=isis.git;h=877e7ed ]

ISIS-837: remove guard which prevents flushing of properties that have NotPersistedFacet.class

(eg annotated with javax.jdo.annotations.NotPersistent)


> In Wicket viewer, forms not flushing properties when annotated with JDO @NotPersistent.
> ---------------------------------------------------------------------------------------
>
>                 Key: ISIS-837
>                 URL: https://issues.apache.org/jira/browse/ISIS-837
>             Project: Isis
>          Issue Type: Bug
>          Components: Viewer: Wicket
>    Affects Versions: viewer-wicket-1.5.0
>            Reporter: Dan Haywood
>            Assignee: Dan Haywood
>            Priority: Minor
>             Fix For: viewer-wicket-1.6.0
>
>
> In 1.5.0 there is a guard to explicitly not flush changed property values in a form's model (EntityModel#apply) for those properties that have the NotPersistedFacet.class.
> However, this logic is wrong.  Even though a property is not directly persistable by JDO, it might still be implicitly persistable through business logic in the setter.
> Therefore remove this guard.



--
This message was sent by Atlassian JIRA
(v6.2#6252)