You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/04/05 04:53:59 UTC

[GitHub] [airflow] cmdoptesc commented on issue #5032: [AIRFLOW-4232] Add `none_skipped` trigger rule

cmdoptesc commented on issue #5032: [AIRFLOW-4232] Add `none_skipped` trigger rule
URL: https://github.com/apache/airflow/pull/5032#issuecomment-480147897
 
 
   Hi @kaxil thanks for looking into my PR.
   
   Currently, `all_done` counts `skipped` as a "done" state (along with `success`, `failed`, and `upstream_failed`), as evidenced here:
   
   https://github.com/apache/airflow/blob/ad602391d600d8feadb240e5e5265c077e741de2/airflow/ti_deps/deps/trigger_rule_dep.py#L72
   
   So unfortunately `all_done` is not a replacement for `none_skipped`.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services