You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by mg...@apache.org on 2016/11/15 21:42:17 UTC
[3/3] wicket git commit: Minor improvements to
ApacheLicenseHeaderTestCase
Minor improvements to ApacheLicenseHeaderTestCase
Project: http://git-wip-us.apache.org/repos/asf/wicket/repo
Commit: http://git-wip-us.apache.org/repos/asf/wicket/commit/39047545
Tree: http://git-wip-us.apache.org/repos/asf/wicket/tree/39047545
Diff: http://git-wip-us.apache.org/repos/asf/wicket/diff/39047545
Branch: refs/heads/master
Commit: 390475455a512819287f27467d3e17ceeb7d7f6c
Parents: a42a27b
Author: Martin Tzvetanov Grigorov <mg...@apache.org>
Authored: Tue Nov 15 22:35:51 2016 +0100
Committer: Martin Tzvetanov Grigorov <mg...@apache.org>
Committed: Tue Nov 15 22:39:12 2016 +0100
----------------------------------------------------------------------
.../util/license/ApacheLicenseHeaderTestCase.java | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/wicket/blob/39047545/wicket-util/src/main/java/org/apache/wicket/util/license/ApacheLicenseHeaderTestCase.java
----------------------------------------------------------------------
diff --git a/wicket-util/src/main/java/org/apache/wicket/util/license/ApacheLicenseHeaderTestCase.java b/wicket-util/src/main/java/org/apache/wicket/util/license/ApacheLicenseHeaderTestCase.java
index be04817..b39e7c3 100644
--- a/wicket-util/src/main/java/org/apache/wicket/util/license/ApacheLicenseHeaderTestCase.java
+++ b/wicket-util/src/main/java/org/apache/wicket/util/license/ApacheLicenseHeaderTestCase.java
@@ -45,7 +45,7 @@ public abstract class ApacheLicenseHeaderTestCase extends Assert
private static final String LINE_ENDING = System.getProperty("line.separator");
- static interface FileVisitor
+ interface FileVisitor
{
/**
* @param file
@@ -83,13 +83,13 @@ public abstract class ApacheLicenseHeaderTestCase extends Assert
}
else
{
- log.info("File ignored: '{}'", pathname.toString());
+ log.debug("File ignored: '{}'", pathname);
}
}
}
else
{
- log.info("File ignored: '{}'", pathname.toString());
+ log.debug("File ignored: '{}'", pathname);
}
}
@@ -146,7 +146,7 @@ public abstract class ApacheLicenseHeaderTestCase extends Assert
private class DirectoryFileFilter implements FileFilter
{
- private final String[] ignoreDirectory = new String[] { ".svn" };
+ private final String[] ignoreDirectory = new String[] { ".git" };
@Override
public boolean accept(final File pathname)
@@ -159,7 +159,7 @@ public abstract class ApacheLicenseHeaderTestCase extends Assert
relativePathname = Strings.replaceAll(relativePathname,
baseDirectory.getAbsolutePath() + System.getProperty("file.separator"), "")
.toString();
- if (relativePathname.equals("target") == false)
+ if ("target".equals(relativePathname) == false)
{
boolean found = false;
for (String ignore : ignoreDirectory)
@@ -307,7 +307,7 @@ public abstract class ApacheLicenseHeaderTestCase extends Assert
ILicenseHeaderHandler licenseHeaderHandler = entry.getKey();
List<File> fileList = entry.getValue();
- failString.append("\n");
+ failString.append('\n');
failString.append(licenseHeaderHandler.getClass().getName());
failString.append(" failed. The following files(");
failString.append(fileList.size());
@@ -329,7 +329,7 @@ public abstract class ApacheLicenseHeaderTestCase extends Assert
failString.append(licenseType);
}
- failString.append(" ").append(filename).append(LINE_ENDING);
+ failString.append(' ').append(filename).append(LINE_ENDING);
}
}