You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2021/08/07 10:22:16 UTC

[GitHub] [mesos] cf-natali opened a new pull request #402: Fixed NestedMesosContainerizerTest hangs on errors.

cf-natali opened a new pull request #402:
URL: https://github.com/apache/mesos/pull/402


   Those tests would use a named pipe to synchronize with the task being
   started.
   The problem is that if the task fails to start, reading from the pipe
   would block indefinitely, making the tests just hang.
   We could update the code to use a read with a timeout, however it's a
   bit fiddly and it's simpler to just use the presence as a regular file
   as a barrier.
   
   See https://issues.apache.org/jira/browse/MESOS-10226 for context.
   Tested by @martin-g  
   
   @qianzhangxa 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mesos] asfgit closed pull request #402: Fixed NestedMesosContainerizerTest hangs on errors.

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #402:
URL: https://github.com/apache/mesos/pull/402


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mesos] qianzhangxa commented on pull request #402: Fixed NestedMesosContainerizerTest hangs on errors.

Posted by GitBox <gi...@apache.org>.
qianzhangxa commented on pull request #402:
URL: https://github.com/apache/mesos/pull/402#issuecomment-895266629


   I have merged this PR, thanks @cf-natali for your contributions!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org